Page MenuHomeVyOS Platform
Create Task
Maniphest T4270

dns forwarding - When "ignore-hosts-file" is unset, local hostname of router resolves to 127.0.1.1
Closed, ResolvedPublicBUG
Actions

Description

Imagine the following DNS forwarding configuration:

set service dns forwarding allow-from '172.16.0.0/12'
set service dns forwarding listen-address '172.16.254.30'
set service dns forwarding listen-address '172.31.0.254'
set service dns forwarding negative-ttl '60'
set system domain-name 'mybll.net'
set system host-name 'BR1.wue3'

Clients using VyOS as their DNS server and trying to resolve BR1.wue3.mybll.net will receive 127.0.1.1 as answer.

We should not render our FQDN to the /etc/hosts file

### Autogenerated by VyOS ###
### Do not edit, your changes will get overwritten ###

# Local host
127.0.0.1       localhost
127.0.1.1       BR1.wue3.mybll.net BR1.wue3
# The following lines are desirable for IPv6 capable hosts
::1             localhost ip6-localhost ip6-loopback
fe00::0         ip6-localnet
ff00::0         ip6-mcastprefix
ff02::1         ip6-allnodes
ff02::2         ip6-allrouters

Details

Difficulty level
Easy (less than an hour)
Version
1.3.0
Why the issue appeared?
Design mistake
Is it a breaking change?
Behavior change
Issue type
Bug (incorrect behavior)

Related Objects

Event Timeline

c-po created this task.Feb 24 2022, 8:25 PM
pasik added a subscriber: pasik.Feb 25 2022, 8:48 AM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.2); removed VyOS 1.3 Equuleus.Aug 14 2022, 1:05 PM
dmbaturin edited projects, added VyOS 1.3 Equuleus (1.3.3); removed VyOS 1.3 Equuleus (1.3.2).Aug 14 2022, 6:15 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.4); removed VyOS 1.3 Equuleus (1.3.3).Jul 12 2023, 9:46 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.5); removed VyOS 1.3 Equuleus (1.3.4).Aug 25 2023, 9:29 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.6); removed VyOS 1.3 Equuleus (1.3.5).Dec 17 2023, 11:36 PM
dmbaturin triaged this task as High priority.Jan 10 2024, 9:20 PM
dmbaturin added projects: VyOS 1.4 Sagitta, VyOS 1.5 Circinus.
c-po claimed this task.Jan 11 2024, 3:42 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.7); removed VyOS 1.3 Equuleus (1.3.6).Feb 10 2024, 9:17 AM
c-po added a comment.Feb 27 2024, 9:27 PM

We should keep this behavior in 1.3.7 but change it for 1.4 and onwards

c-po removed a project: VyOS 1.3 Equuleus (1.3.7).Feb 27 2024, 9:28 PM
c-po changed Difficulty level from Unknown (require assessment) to Easy (less than an hour).
c-po changed Why the issue appeared? from Will be filled on close to Design mistake.
c-po changed Is it a breaking change? from Unspecified (possibly destroys the router) to Behavior change.
c-po changed Issue type from Unspecified (please specify) to Bug (incorrect behavior).
c-po closed this task as Resolved.Feb 28 2024, 7:33 PM
c-po moved this task from Need Triage to 1.4.0-epa1 on the VyOS 1.4 Sagitta board.
c-po edited projects, added VyOS 1.4 Sagitta (1.4.0-epa1); removed VyOS 1.4 Sagitta.
c-po moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta (1.4.0-epa1) board.
c-po moved this task from Need Triage to Finished on the VyOS 1.5 Circinus board.
Aldemaro added a subscriber: Aldemaro.Feb 29 2024, 12:19 PM

That commit has the side effect that using sudo or even just committing some configurations will return "sudo: unable to resolve host vyos: System error" every time. Applications that rely on the system hostname will also not be able to reach localhost if the hostname is not a FQDN.

I don't see why that should be the case instead of just using "set service dns forwarding ignore-hosts-file".

Maybe we could just add "127.0.1.1 {{ host_name }}" to /etc/hosts and leave de domain name out?

krox2 added a subscriber: krox2.Feb 29 2024, 2:09 PM
c-po added a comment.Feb 29 2024, 9:11 PM

https://github.com/vyos/vyos-1x/pull/3066

dmbaturin edited projects, added VyOS 1.4 Sagitta (1.4.0-epa2); removed VyOS 1.4 Sagitta (1.4.0-epa1).Mar 11 2024, 6:46 PM
Viacheslav mentioned this in T2279: Router resolves as 127.0.1.1 when using Router's Recursive DNS.Fri, Apr 26, 12:05 PM