Page MenuHomeVyOS Platform
Create Task
Maniphest T4689

Support RFS(Receive Flow Steering)
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

vyos has supported RPS for a long time, but sometimes it is better to have RFS with RPS

sysctl -w net.core.rps_sock_flow_entries=32768
echo 32768/N > /sys/class/net/eth5/queues/rx-0/rps_flow_cnt

N: Usually should be the number of queues

note: https://lwn.net/Articles/381955/

Details

Difficulty level
Unknown (require assessment)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Unspecified (please specify)

Event Timeline

jack9603301 renamed this task from Support RFS to Support RFS(Receive Flow Steering).Sep 11 2022, 2:39 PM
jack9603301 created this task.
jack9603301 updated the task description. (Show Details)Sep 11 2022, 2:41 PM
jack9603301 updated the task description. (Show Details)Sep 11 2022, 2:44 PM
pasik added a subscriber: pasik.Sep 11 2022, 3:30 PM
jack9603301 changed the task status from Open to In progress.Sep 11 2022, 4:37 PM
jack9603301 claimed this task.
jack9603301 moved this task from Need Triage to In Progress on the VyOS 1.4 Sagitta board.
jack9603301 added a comment.Sep 11 2022, 7:09 PM

PR: https://github.com/vyos/vyos-1x/pull/1533

jack9603301 changed the task status from In progress to Needs testing.Sep 12 2022, 6:53 AM
jack9603301 moved this task from In Progress to Finished on the VyOS 1.4 Sagitta board.
jack9603301 added a comment.Sep 15 2022, 9:44 AM

https://github.com/vyos/vyos-1x/pull/1535

jack9603301 added a subscriber: c-po.Sep 15 2022, 6:45 PM

I re-reviewed this PR and the following commit from @c-po

https://github.com/vyos/vyos-1x/commit/3e24e673537c0ae59a1d1012f9b70920294caba2

Apparently I've always felt like there was a problem somewhere, and now, I know, it introduced a bug if the following commit existed:

set interfaces ethernet eth0 offload rfs
set interfaces ethernet eth1 offload rfs
commit
del interfaces ethernet eth1 offload rfs
commit

For the local rfs of the device, the reset is successful, but it also erases the setting information of the global rfs table, and eth0 is still starting the rfs

I'll make a fix PR in the future

jack9603301 added a comment.Sep 17 2022, 12:27 PM

PR: https://github.com/vyos/vyos-1x/pull/1542

Apachez added a subscriber: Apachez.Aug 25 2023, 9:11 PM
dmbaturin closed this task as Resolved.Jan 10 2024, 10:46 PM