Page MenuHomeVyOS Platform

build linux-firmware script cannot expand asterisks if firmware name is a glob string
Closed, ResolvedPublicBUG

Description

build linux-firmware script cannot expend star sign if firmware name is a glob string
For example: brcmfmac firmware has "brcm/brcmfmac*-sdio.*.bin". and this firmware path/name should be expanded again.
L58 cannot expand wildcard again.
So linux-firmware deb didn't contain all firmware that driver required.

firmware:       brcm/brcmfmac*-sdio.*.bin
firmware:       brcm/brcmfmac*-sdio.*.txt
firmware:       brcm/brcmfmac43752-sdio.clm_blob
firmware:       brcm/brcmfmac43752-sdio.bin
firmware:       brcm/brcmfmac43012-sdio.clm_blob
firmware:       brcm/brcmfmac43012-sdio.bin
firmware:       brcm/brcmfmac4373-sdio.clm_blob
firmware:       brcm/brcmfmac4373-sdio.bin
firmware:       brcm/brcmfmac4359-sdio.bin
firmware:       brcm/brcmfmac4356-sdio.clm_blob
firmware:       brcm/brcmfmac4356-sdio.bin
firmware:       brcm/brcmfmac4354-sdio.clm_blob
firmware:       brcm/brcmfmac4354-sdio.bin
firmware:       brcm/brcmfmac43456-sdio.bin
firmware:       brcm/brcmfmac43455-sdio.clm_blob
firmware:       brcm/brcmfmac43455-sdio.bin
firmware:       brcm/brcmfmac43439-sdio.clm_blob
firmware:       brcm/brcmfmac43439-sdio.bin
firmware:       brcm/brcmfmac43430b0-sdio.bin
firmware:       brcm/brcmfmac43430-sdio.clm_blob
firmware:       brcm/brcmfmac43430-sdio.bin
firmware:       brcm/brcmfmac43430a0-sdio.bin
firmware:       brcm/brcmfmac4339-sdio.bin
firmware:       brcm/brcmfmac43362-sdio.bin
firmware:       brcm/brcmfmac4335-sdio.bin
firmware:       brcm/brcmfmac43340-sdio.bin
firmware:       brcm/brcmfmac4334-sdio.bin
firmware:       brcm/brcmfmac4330-sdio.bin
firmware:       brcm/brcmfmac4329-sdio.bin
firmware:       brcm/brcmfmac43241b5-sdio.bin
firmware:       brcm/brcmfmac43241b4-sdio.bin
firmware:       brcm/brcmfmac43241b0-sdio.bin
firmware:       brcm/brcmfmac43143-sdio.bin
firmware:       brcm/brcmfmac4373.bin
firmware:       brcm/brcmfmac43569.bin
firmware:       brcm/brcmfmac43242a.bin
firmware:       brcm/brcmfmac43236b.bin
firmware:       brcm/brcmfmac43143.bin
firmware:       brcm/brcmfmac*-pcie.*.clm_blob
firmware:       brcm/brcmfmac*-pcie.*.bin
firmware:       brcm/brcmfmac*-pcie.*.txt
firmware:       brcm/brcmfmac*-pcie.txt
firmware:       brcm/brcmfmac89459-pcie.bin
firmware:       brcm/brcmfmac4378b1-pcie.clm_blob
firmware:       brcm/brcmfmac4378b1-pcie.bin
firmware:       brcm/brcmfmac4371-pcie.bin
firmware:       brcm/brcmfmac4366c-pcie.bin
firmware:       brcm/brcmfmac4366b-pcie.bin
firmware:       brcm/brcmfmac4365c-pcie.bin
firmware:       brcm/brcmfmac4365b-pcie.bin
firmware:       brcm/brcmfmac4364-pcie.bin
firmware:       brcm/brcmfmac4359-pcie.bin
firmware:       brcm/brcmfmac4358-pcie.bin
firmware:       brcm/brcmfmac43570-pcie.clm_blob
firmware:       brcm/brcmfmac43570-pcie.bin
firmware:       brcm/brcmfmac4356-pcie.clm_blob
firmware:       brcm/brcmfmac4356-pcie.bin
firmware:       brcm/brcmfmac4350c2-pcie.bin
firmware:       brcm/brcmfmac4350-pcie.bin
firmware:       brcm/brcmfmac43602-pcie.bin

https://github.com/vyos/vyos-build/blob/current/packages/linux-kernel/build-linux-firmware.sh#L58

Details

Difficulty level
Unknown (require assessment)
Version
1.4-rolling
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Event Timeline

Raspberry pi 4 wifi driver requires some missing files.

dmbaturin renamed this task from build linux-firmware script cannot expend star sign if firmware name is a glob string to build linux-firmware script cannot expand asterisks if firmware name is a glob string.Aug 27 2023, 4:33 PM
dmbaturin changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.
dmbaturin changed Issue type from Unspecified (please specify) to Bug (incorrect behavior).
dmbaturin claimed this task.