Page MenuHomeVyOS Platform

Add logging for which mksquashfs syntax is being used
In progress, NormalPublicFEATURE REQUEST

Description

When building VyOS then mksquashfs is being used to create the filesystem.squashfs file.

However since the syntax is compiled dynamically (by vyos-live-build/scripts/build/binary_rootfs) its hard to tell afterwards what the full syntax of mksquashfs really were to create that squashfs-file.

Suggestion to add some logging at around https://github.com/vyos/vyos-live-build/blob/current/scripts/build/binary_rootfs#L324 what the variable ${MKSQUASHFS_OPTIONS} ultimately ended up to be.

Details

Difficulty level
Unknown (require assessment)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Feature (new functionality)

Event Timeline

PR1 didnt seem to have any affect on this night build:

https://github.com/vyos/vyos-rolling-nightly-builds/actions/runs/6018937596/job/16328001449#step:8:6563

Which gives... what other source file mus be altered for this logging to work properly?

https://github.com/search?q=org%3Avyos%20mksquashfs&type=code

I have created a PR upstream which hopefully resolves why the logging didnt work as expected in VyOS (since the binary_rootfs in vyos-live-build isnt used by the nightly build who uses vyos-build and the deb-package of live-build from Debian 12.x (bookworm)):

https://salsa.debian.org/live-team/live-build/-/merge_requests/322

@Apachez note that all lb commands take --debug and --verbose: using 'lb build --debug' in scripts/build-vyos-image will output the full mksquashfs command.

@jestabro I havent verified it yet but then perhaps the buildscript for VyOS should be altered to include --verbose?

Note that is is the "--debug" flag that one wants in order to see the full mksquashfs command that is executed.

Shouldnt that be default for lb then in the vyos buildscripts and how does --debug affect things other than logging during build?

Viacheslav changed the task status from Open to In progress.Jan 20 2024, 1:12 PM
Viacheslav triaged this task as Normal priority.
Viacheslav added a project: VyOS 1.5 Circinus.

Removed assignee for now in case somebody else wants to fix this?