Page MenuHomeVyOS Platform

Clarify the error message when trying to set an interface as a BGP peer group using the wrong syntax
Confirmed, LowPublicBUG

Description

There is an issues related when we wants to add a interface within bgp peer-group , it shows a error message that it partially breaks the bgp configuration for e.g:

set protocols bgp 64802 address-family ipv4-unicast redistribute connected
set protocols bgp 64802 listen range 10.10.100.0/24 peer-group 'FOO'
set protocols bgp 64802 neighbor eth1 peer-group 'FOO'
set protocols bgp 64802 parameters router-id '10.10.100.1'
set protocols bgp 64802 peer-group FOO address-family ipv4-unicast
set protocols bgp 64802 peer-group FOO remote-as '64802'
set protocols bgp 64802 peer-group FOO update-source 'eth1'

error message :

vyos@vyos# commit
[ protocols bgp 64802 ]
% Malformed address or name: eth1
Error configuring routing subsystem.  See log for more detailed information

it seems that this issues is related to FRR , they allow to configure it but misunderstanding the Ethernet interfaces :

vyos@vyos# sudo vtysh -c "show run"
Building configuration...

Current configuration:
!
frr version 7.5.1-20230529-02-gba1778129
frr defaults traditional
!
router bgp 64802
 bgp router-id 10.10.100.1
 no bgp ebgp-requires-policy
 no bgp network import-check
 neighbor FOO peer-group
 neighbor FOO remote-as 64802
 neighbor FOO update-source eth1
!
line vty
!

vyos(config-router)# neighbor eth1 peer-group FOO
% Malformed address or name: eth1

FRR doesn't say nothing related to it on their documentation , in fact , they don't recommend its use :

http://docs.frrouting.org/en/stable-7.5/bgp.html#clicmd-[no]neighborPEERinterfaceIFNAME

Details

Difficulty level
Normal (likely a few hours)
Version
VyOS 1.3.3
Why the issue appeared?
Implementation mistake
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Event Timeline

fernando changed the task status from Open to Confirmed.Aug 30 2023, 6:05 PM
fernando created this task.
fernando edited projects, added VyOS 1.3 Equuleus (1.3.4); removed VyOS 1.3 Equuleus.

If you use interface as a peer, you have to use interface peer-group
in FRR

r1(config-router)# neighbor eth1 interface peer-group

VyOS

vyos@r1# set protocols bgp 65001 neighbor eth1 interface peer-group 
Possible completions:
   <text>       peer group for this peer
dmbaturin renamed this task from BGP peer-group - don't support add interfaces over peer neigborhs to Clarify the error message when trying to set an interface as a BGP peer group using the wrong syntax.Sep 25 2023, 1:27 PM
dmbaturin changed Why the issue appeared? from Will be filled on close to Implementation mistake.
dmbaturin changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.