Page MenuHomeVyOS Platform
Create Task
Maniphest T5983

image-tools: minor regression in pruning version files in compatibility mode
Closed, ResolvedPublicBUG
Actions

Description

This is a 'minor' issue as the bug has no effect, but to leave ignored version files if an image was removed by legacy tools; it is listed as 'high' priority, as we want to backport all fixes, minor or not, before the release of 1.4.

It is a regression after
'image-tools: T5831: show system image reverse ordered by date'
which sorts the output of grub.version_list(), but as used in compat.prune_vyos_versions() will have already ignored non-effective version files. The fix is trivial.

Details

Difficulty level
Easy (less than an hour)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Related Objects

Event Timeline

jestabro changed the task status from Open to In progress.Jan 25 2024, 2:24 AM
jestabro triaged this task as High priority.
jestabro created this task.
jestabro created this object in space S1 VyOS Public.
jestabro added a comment.Jan 25 2024, 4:23 AM

PR
https://github.com/vyos/vyos-1x/pull/2893

pasik added a subscriber: pasik.Jan 25 2024, 9:09 AM
jestabro changed the task status from In progress to Backport pending.Jan 25 2024, 2:27 PM
jestabro moved this task from Need Triage to Finished on the VyOS 1.5 Circinus board.
jestabro closed this task as Resolved.Jan 25 2024, 9:18 PM
jestabro moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.