Page MenuHomeVyOS Platform
Create Task
Maniphest T6065

Duplicate lines in build-vyos-image script cause sagitta build to fail
Closed, ResolvedPublicBUG
Actions

Description

In recent commit #273d624 the build-vyos-image script was modified but lines 334-339 were identical to lines 361-366, which is causing the build to fail with the following error:

Traceback (most recent call last):

File "/__w/vyos-build/vyos-build/vyos-build/./build-vyos-image", line 366, in <module>
  os.chdir(defaults.BUILD_DIR)

FileNotFoundError: [Errno 2] No such file or directory: 'build'
Error: Process completed with exit code 1.

Essentially the script will attempt twice to chdir to 'build' which succeeds the first time but fails the 2nd as it is already in the build directory.

Details

Difficulty level
Easy (less than an hour)
Version
sagitta
Why the issue appeared?
Implementation mistake
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Event Timeline

hcuk94 created this task.Feb 25 2024, 2:47 PM
hcuk94 added a comment.Feb 25 2024, 2:58 PM

I have created a PR to resolve this issue: https://github.com/vyos/vyos-build/pull/511

pasik added a subscriber: pasik.Feb 25 2024, 3:20 PM
GurliGebis added a subscriber: GurliGebis.Feb 25 2024, 8:03 PM
dmbaturin triaged this task as Unbreak Now! priority.Feb 26 2024, 9:48 PM
dmbaturin changed Why the issue appeared? from Will be filled on close to Implementation mistake.
dmbaturin changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.
dmbaturin changed Issue type from Unspecified (please specify) to Bug (incorrect behavior).
hcuk94 closed this task as Resolved.Feb 27 2024, 11:09 PM
hcuk94 claimed this task.

This was resolved by merged PR. Build process now succeeds.

Viacheslav moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.Feb 28 2024, 8:14 AM