Page MenuHomeVyOS Platform
Create Task
Maniphest T6072

https api cors allow-origin not applied
Open, WishlistPublicFEATURE REQUEST
Actions

Description

Hello,

It appears that CLI command:

# set service https api cors allow-origin '*'

has no effect on VyOS HTTPS API but only on GraphQL API (see T4076 issue)

https://github.com/vyos/vyos-1x/blob/0be3d1f64bea6e3b52f58a1da056179f88baff9d/src/services/vyos-http-api-server#L820

could you check?

thanks

Details

Difficulty level
Unknown (require assessment)
Version
1.4.0
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Unspecified (please specify)

Related Objects

Event Timeline

vse-github renamed this task from https api cors allowed-origin not applied to https api cors allow-origin not applied.Feb 27 2024, 11:18 AM
vse-github created this task.
vse-github edited projects, added VyOS 1.4 Sagitta; removed VyOS 1.4 Sagitta (1.4.0).Feb 27 2024, 11:20 AM
pasik added a subscriber: pasik.Feb 27 2024, 1:13 PM
jestabro added a subscriber: jestabro.Feb 27 2024, 1:20 PM

Yes, this is only used by the GraphQL API.

vse-github added a comment.Mar 1 2024, 9:21 AM

is it possible to extend this feature to json api of vyos?

Viacheslav triaged this task as Wishlist priority.Mar 2 2024, 11:18 AM
Viacheslav changed the subtype of this task from "Bug" to "Feature Request".Fri, Apr 12, 2:11 PM
Viacheslav edited projects, added VyOS 1.5 Circinus; removed VyOS 1.4 Sagitta.
Embezzle added a subscriber: Embezzle.Mon, Apr 22, 1:43 PM