Maniphest T6093

Incorrect dhcp-options vendor-class-id regex
Closed, ResolvedPublicBUG
Actions

Assigned To

Authored By

	unixsh
	Mar 4 2024, 12:19 PM

Tags

Referenced Files

None

Subscribers

Description

I’ve found a bug in the 1.4.0-EPA1 regarding the dhcp-options vendor-class-id validation.
The regex used to validate the entry doesn’t take the string if it contains dot, which can be required by some ISP as mine.

I've just added a dot in the first regex to make it work on my installation, but I'm not used to them so I'm not sure if it was the proper way to do it.

Details

Difficulty level: Easy (less than an hour)
Version: 1.4.0-EPA1
Why the issue appeared?: Implementation mistake
Is it a breaking change?: Behavior change
Issue type: Bug (incorrect behavior)

Event Timeline

unixsh created this task.Mar 4 2024, 12:19 PM

Viacheslav triaged this task as Normal priority.Mar 4 2024, 2:03 PM

unixsh edited projects, added VyOS 1.4 Sagitta (1.4.0-epa1); removed VyOS 1.4 Sagitta.Mar 4 2024, 2:20 PM

pasik added a subscriber: pasik.Mar 4 2024, 6:02 PM

unixsh changed Why the issue appeared? from Will be filled on close to Implementation mistake.Mar 5 2024, 1:35 PM

The regex should be [-_a-zA-Z0-9.\s]+ instead of [-_a-zA-Z0-9\s]+

I'm trying to figure how to run the smoke tests to create the PR myself.

Create the PR without smoketest. This case is not tested.

c-po changed the task status from Open to In progress.Mar 10 2024, 7:09 PM

c-po assigned this task to unixsh.

c-po added a project: VyOS 1.5 Circinus.

c-po moved this task from Need Triage to Finished on the VyOS 1.5 Circinus board.

PR for 1.4 https://github.com/vyos/vyos-1x/pull/3118

Viacheslav closed this task as Resolved.Mar 11 2024, 8:30 AM

Viacheslav reassigned this task from unixsh to c-po.

Viacheslav moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta (1.4.0-epa1) board.

dmbaturin renamed this task from Dhcp-options vendor-class-id regex to Incorrect dhcp-options vendor-class-id regex.Mar 11 2024, 6:58 PM

dmbaturin edited projects, added VyOS 1.4 Sagitta (1.4.0-epa2); removed VyOS 1.4 Sagitta (1.4.0-epa1).