Page MenuHomeVyOS Platform
Create Task
Maniphest T629

Migration scripts insert "commit-revisions 20" into system config-management even if commit-revisions option is already present
Closed, ResolvedPublicBUG
Actions

Description

This is harmless, but is indicative of some odd logic in the migration script.

Details

Difficulty level
Unknown (require assessment)
Version
1.2.0
Why the issue appeared?
Will be filled on close

Event Timeline

dmbaturin created this task.May 10 2018, 11:40 PM
syncer triaged this task as Normal priority.May 27 2018, 9:33 AM
syncer edited projects, added VyOS 1.2 Crux (VyOS 1.2.0-rc1); removed VyOS 1.2 Crux.
dmbaturin claimed this task.May 31 2018, 1:41 AM
dmbaturin edited projects, added VyOS 1.2 Crux; removed VyOS 1.2 Crux (VyOS 1.2.0-rc1).
dmbaturin moved this task from Need Triage to In Progress on the VyOS 1.2 Crux board.

The fault was in XorpConfigParser, whose "set" function behaves as if all nodes were multi nodes, so it was adding a value where none was needed (that's on top of the fact that it didn't properly check if it exists).

With the new library, that's no longer an issue.

dmbaturin closed this task as Resolved.Aug 4 2018, 6:57 PM
dmbaturin edited projects, added VyOS 1.2 Crux (VyOS 1.2.0-rc1); removed VyOS 1.2 Crux.
syncer added a project: VyOS-1.2.0-GA.Oct 15 2018, 10:42 PM
syncer moved this task from Needs Triage to Finished on the VyOS 1.2 Crux (VyOS 1.2.0-rc1) board.Oct 15 2018, 10:42 PM