Page MenuHomeVyOS Platform
Create Task
Maniphest T6305

IPoE interface wildcard validation error in firewall rules
Closed, ResolvedPublicBUG
Actions

Description

Validator does not allow wildcards but should

vyos@r4# set firewall ipv4 forward filter rule 1010 inbound-interface name 
Possible completions:
   <text>               Interface name
   txt*                 Interface name with wildcard
   ...

Example all ipoe interfaces:

vyos@r4# set firewall ipv4 forward filter rule 1010 inbound-interface name 'ipoe*'

  
  
  
  Invalid value
  Value validation failed
  Set failed

Details

Difficulty level
Easy (less than an hour)
Version
VyOS 1.5-rolling-202405010020
Why the issue appeared?
Implementation mistake
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Event Timeline

Viacheslav triaged this task as Normal priority.Sat, May 4, 10:49 AM
Viacheslav created this task.
Embezzle added a subscriber: Embezzle.Sun, May 5, 5:21 PM
n.fort claimed this task.Mon, May 6, 7:14 PM
pasik added a subscriber: pasik.Mon, May 6, 8:17 PM
Viacheslav renamed this task from Firewall interface wildcard validation error to Firewall ipoe interface wildcard validation error.Tue, May 7, 2:58 PM
n.fort changed the task status from Open to In progress.Tue, May 7, 3:06 PM
n.fort added a comment.Tue, May 7, 3:25 PM

PR: https://github.com/vyos/vyos-1x/pull/3424

Apachez added a subscriber: Apachez.Tue, May 7, 4:50 PM

Shouldnt this be adjusted in more files and places?

Note that below is just an example, the below search might have missed some spots:

https://github.com/search?q=repo%3Avyos%2Fvyos-1x%20gnv%7Cifb&type=code

n.fort closed this task as Resolved.Wed, May 8, 4:19 PM
n.fort moved this task from Need Triage to Finished on the VyOS 1.5 Circinus board.
dmbaturin renamed this task from Firewall ipoe interface wildcard validation error to IPoE interface wildcard validation error in firewall rules.Sat, May 11, 8:13 PM
dmbaturin edited projects, added VyOS 1.4 Sagitta (1.4.0-epa3); removed Restricted Project, VyOS 1.5 Circinus.
dmbaturin changed Why the issue appeared? from Will be filled on close to Implementation mistake.
dmbaturin changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.
dmbaturin changed Issue type from Unspecified (please specify) to Bug (incorrect behavior).