Maniphest T6310

Change branches for CodeQL on push
Closed, ResolvedPublicFEATURE REQUEST
Actions

Assigned To

Authored By

	Viacheslav
	Tue, May 7, 7:53 AM

Tags

Referenced Files

None

Subscribers

Description

Currently, we have crux and do not have sagitta in the branches https://github.com/vyos/vyos-1x/blob/5b2436fbec8e5279c8b27c03819b1607c1eca0af/.github/workflows/codeql-caller.yml#L17
It needs to fix it.
The crux is EOL and should be removed from the checking code.
Check branch names, some with double quotes, others without quotes.

Details

Difficulty level: Unknown (require assessment)
Version: -
Why the issue appeared?: Will be filled on close
Is it a breaking change?: Unspecified (possibly destroys the router)
Issue type: Unspecified (please specify)

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open	FEATURE REQUEST	Vijayakumar	T6309 Git integration CodeQL root task
		Resolved	FEATURE REQUEST	Vijayakumar	T6310 Change branches for CodeQL on push

Event Timeline

Viacheslav assigned this task to Vijayakumar.Tue, May 7, 7:53 AM

Viacheslav created this task.

Viacheslav updated the task description. (Show Details)Tue, May 7, 7:56 AM

Viacheslav updated the task description. (Show Details)

Added reusable workflow for codeql
Please review and approve
https://github.com/vyos/vyos-github-actions/pull/2

pasik added a subscriber: pasik.Tue, May 7, 10:06 AM

Used codeql reusable workflow in a reference repo.
Please review and merge
https://github.com/vyos/vyos-1x/pull/3420

Few PR checks failing, i will check and fix

Viacheslav triaged this task as Normal priority.Tue, May 7, 3:34 PM

https://github.com/vyos/vyos-1x/pull/3421 Merged

Vijayakumar closed this task as Resolved.Tue, May 7, 6:26 PM

Viacheslav moved this task from Need Triage to Finished on the VyOS 1.5 Circinus board.Wed, May 8, 6:17 AM

syncer edited projects, added GitHub Infrastructure; removed VyOS 1.5 Circinus.Wed, May 8, 11:50 AM