Page MenuHomeVyOS Platform

need to add automatic assignment of reviewers from reviewers team
Closed, ResolvedPublicFEATURE REQUEST

Description

Hello,
We already have this functionality on repos
need to streamline workflow and include it in the library of reusable workflows so we can apply this to other repositories
in a nutshell, the workflow should assign reviewers to PR from the Reviewers GitHub team

Details

Difficulty level
Unknown (require assessment)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Improvement (missing useful functionality)

Event Timeline

syncer triaged this task as Normal priority.Wed, May 8, 11:42 AM

@syncer Just want to know whether we considered using the CODEOWNERS file to achieve this
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

For example adding CODEOWNERS file with below in the repository.

* @vyos/reviewers

This should automatically assign the reviewer for PR as reviewers team.

Note
This file can be added in vyos/.github repository if the same reviewers team is to be set for all repositories. (No need to add in each repo)

Added access to organization's .github repository
we probably want to keep PR templates and what else there too(will create separate task)

Added codeowner file and basis pr templates and checks
https://github.com/vyos/.github/pull/1
Please review the PR

@syncer Any idea why conflict check fails for this PR https://github.com/vyos/vyos-1x/actions/runs/9015620312 ?

says

 for PR "T5873: ipsec remote access VPN: support VTI interfaces.": add "state: conflict", remove "state: conflict resolved"
Issue #3221 does not have label 'state: conflict resolved'. No need to remove.

This PR merged. Closing the issue