Put in pull request https://github.com/vyos/vyos-1x/pull/1423

I wanted to ask you guys if this is an appropriate change to make. Considering it's on BGP, it's going to be a change in a crucial part but I think this one is probably a good one to make just to reduce ambiguity.

@c-po, lets run with "system-as"

@Viacheslav, hmmm, yeah that's a good point. I'll see what I can do to add the OP configs. I know I added the conf configs.

Now that's......different.

Did more checks.....and noticed it *IS* properly sending the ping command:

Made the change to "do" and I noticed that.....DF is used even if there is no DF bit explicitly set...:

It seems the man page that I looked at I either didn't read carefully enough, or I completely messed it up. You're right @Viacheslav.

Did a quick test...

Hmmmm....it worked last time. I'll give it another run.

Put in a PR for this....

@Scoopta, thank you. That's good. I *think* know how the logic should go. Shouldn't be difficult but I'll consult with @Viacheslav and @c-po on how we should tackle it. It shouldn't be hard, but I want to make sure I properly do it :)

@Viacheslav, @c-po, the ISIS FRR Jinja2 template is significantly different between 1.3 and 1.4. Should I try to make the change on 1.3 and then merge? Or should I make it on 1.4 and we'll find a way to merge it back into 1.3?

@Viacheslav, @Scoopta, I take it for default originate on IPv6 there's a requirement to have "ipv6 router isis" added on the interface? I'm thinking yes. If it's a yes (which I'm thinking it is) then I believe this should be fairly easy to add. I'll give it a check guys.

Added PR:

@fernando, this was something I was looking into adding but it'll be in 1.4 One day.....I hope soonish....maybe in a few months.

Will be adding the BGP op commands for it as well eventually...

I put in a PR for this:

FRR coder Donald Sharp kicked ass and fixed it here...

I have successfully added a *ton* of address families in my build. I will PR it, but we also have found an error. The error that we have found is an FRR error at this link here.

@c-po, using a value of "0" for use inbound packet would actually be the best behavior if we can specify/use that.

I know my opinion is....really not that important but I would *highly* recommend going to maximum TTL of 255 or at minimum 127. TTL is a very hard thing to troubleshoot most of the time and therefore it's almost never worth going lower than maximum for IP TTL.

Put in a PR for this, https://github.com/vyos/vyos-1x/pull/744

Here is some more testing. Currently on FRR 7.5:

I *think* that there was a fix that happened on a task somewhere by someone in the underlying operating system that happened to fix this problem, but I for the life of me don't know what/where it would be. I'll have to ask around on it as I think there was changes on it 100% certain. The reason is is because I *saw* this problem too on a very old install too but it went away very quickly and I made no changes to fix it.

Just curious.

Hmmm...I am still not able to replicate...

I think we have a workable solution to this.

I can say that after testing here's what I found.

Put in a PR for this request.

In T915#83668, @daniil wrote:

In T915#81521, @Cheeze_It wrote:

See if you can get absolute latest and see if it works...

net.mpls.conf.X.input variable is not set after reboot.

I'd personally recommend "pmtu-discovery-disable", but either would be fine.

Put PR for segment routing addition:

@drac, while yes that is an option I am unsure which VyOS should as a software package should use.

So, this option can be disabled here per the FRR manual:

This is due to RFC 8212, which was added on FRR 7.4. Please see here...

I am wondering if these are Zebra errors as they *seem* like Zebra errors.

Put in PR for op commands:

Put in a PR to add LDP ordered control operation for LDP.

Put in a PR to add op commands for LDP.

Put in a PR to fix spelling/help string error. My bad. I didn't catch it before.

Put in a PR to add documentation for LDP import/export control again. I didn't rebase properly last time. Sorry everyone :(

Put in a PR to add LDP import/export control.

@bbs2web, here's what I got...

@bbs2web, getting this one (https://downloads.vyos.io/rolling/current/amd64/vyos-1.3-rolling-202012070521-amd64.iso) and will troubleshoot...

Put in a new PR to enable LDP local label allocation control.

This will be on my list to test here in a little bit. I'm almost done with stuff relating to LDP.

Put in a new PR to enable ethernet sub interface MPLS enablement. I screwed up the first one...but here's hoping this one is good.

Put in a PR to enable ethernet sub interface MPLS enablement

@bbs2web, I figured it out. I know what's not working.

I just did some testing, and @bbs2web, you're right. Sub interfaces to not get enabled. However main interfaces *DO* get enabled.

Try the new rolling by the way. There was a problem initially that we had to fix. Do like the rolling from 11/25 or tomorrow of 11/26.

@bbs2web, yessir, this is a new changed behavior. In the past when you configured an LDP interface it also enabled MPLS on the same interface.

Put in a PR for refactor of LDP template, MPLS python handler, addition of global MPLS parameters (via Linux kernel config changes), and separation of MPLS interfaces from LDP interfaces. *PLEASE* know I did do testing but I want more people to test as well. I have uploaded the package file for this PR here so that people can test my work.

@bbs2web, oh don't you worry. I've had my eyes on it after I get LDP done. I'm almost done with it too.

Put in a PR to add miscellaneous MPLS and LDP parameters.

Put in a PR to add targeted LDP neighbors.

Sure, no worries. We still have a *ton* of work on 7.3.1 to do so I'm sure we'll get to 7.5 in time :)

Not sure if it's relevant or not, but I think 7.5 was released....we might be able to just leapfrog 7.4 and go directly to 7.5 instead.

Put in a PR to add session hold time for static LDP neighbors.

Put in a PR to add TTL security for static LDP neighbors.

Put in a PR to separate hello/hold timers for IPv4 and IPv6. Added IPv6 timers.

I put a request on this up top. We'll get to it eventually, but I was hoping we could put it like this:

Here is the test for the LDP session time change.

Here is the test for Explicit Null.

Everything seems to be good. Closing case.

Submitted second PR

Submitted PR

I'll be giving those a test once T2981 is done. I'll report back here with results :)

PR is added here...

The last thing I think we can add is the dual stack capability options. We only got 2.

Ok, so here's the import LDP FEC one that I think we could take advantage of as well.

Ok, so here's the export LDP FEC one that I think we could take advantage of.

The one after that I feel would be fairly easy to also implement is customized label allocation. Again, it is under the family of IPv4 or IPv6.

The next one that I think would be fairly easy to add would be the following:

Hello sir. I am unsure if you're able to add more under LDP but I have found others if you possibly could add. They should be simple additions and are already supported under FRR 7.3.1.

The way I was thinking is on this Juniper page here.

In T2898#75677, @jack9603301 wrote:

@Cheeze_It

I also take into account the specific situation of the ndp proxy, the configuration of this link prompts, the configuration format of the ndp proxy is like this.

https://manpages.debian.org/buster/ndppd/ndppd.conf.5.en.html

In T2898#75656, @jack9603301 wrote:

set interfaces ethernet eth0 ip proxy-arp

The more suitable position may be set protocol ndp-proxy

@Viacheslav, I am unsure if you're able to finish the template and/or work on it more but if you guys ever choose to complete it and add it into rolling then I can test it out in my lab.

Not quite sure if this is the right thing to do but, if a "delete protocols ospf" command is given the equivalent in FRR should be "no router ospf".

If you guys want, I can also try to test it out too...

@adestis yes, that is true....but that can be worked around. Any option can be used (either BFD, or ARP, or ICMP). I just wanted to give more ideas so that hopefully can get a working implementation for all 3.