Page MenuHomeVyOS Platform

rhn (thn)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 22 2020, 1:03 PM (214 w, 2 d)

Recent Activity

Aug 26 2021

rhn added a comment to T3754: Make config scripts more testable.

Bump - is anyone interested in reviewing this or at least discussing direction? It's difficult to contribute to stalled projects.

Aug 26 2021, 6:36 AM · VyOS 1.4 Sagitta

Aug 14 2021

rhn added a comment to T3754: Make config scripts more testable.

more amount of generalisation as we would not only want to use it for DHCp but all kind of services

Aug 14 2021, 6:14 PM · VyOS 1.4 Sagitta
rhn added a comment to T3754: Make config scripts more testable.

Thanks, that makes sense. Do you think the current outstanding change could be merged in? It's not resulting in any incompatibilities (that I'm aware of), and while it doesn't fix the problem entirely on its own (doesn't include infrastructure work), it improves the code under test.

Aug 14 2021, 3:53 PM · VyOS 1.4 Sagitta
rhn added a comment to T3754: Make config scripts more testable.

As far as I can tell (from README), smoke tests are meant more to be integration than unit tests:

Aug 14 2021, 12:41 PM · VyOS 1.4 Sagitta
rhn added a comment to T3754: Make config scripts more testable.

I managed to make the DHCP configuration testable, although the code has some hardcoded paths which I didn't want to mess with too much, so my addition may be suboptimal.

Aug 14 2021, 12:04 PM · VyOS 1.4 Sagitta
rhn created T3754: Make config scripts more testable.
Aug 14 2021, 8:10 AM · VyOS 1.4 Sagitta