Page MenuHomeVyOS Platform

BGP conf_mode errors disable-send-community
Open, Requires assessmentPublicBUG

Description

Setting 'disable-send-community' doesn't take effect.

set protocols bgp 65001 neighbor 10.0.0.2 disable-send-community extended
set protocols bgp 65001 neighbor 10.0.0.2 disable-send-community standard
set protocols bgp 65001 neighbor 10.0.0.2 remote-as '65002'

Vtysh

!
router bgp 65001
 neighbor 10.0.0.2 remote-as 65002
!

The handler only for correct afi.

https://github.com/vyos/vyatta-cfg-quagga/blob/current/scripts/bgp/vyatta-bgp.pl#L414

'protocols bgp var neighbor var address-family ipv4-unicast disable-send-community' => {
    set => undef,
    del => undef,
},
'protocols bgp var neighbor var address-family ipv4-unicast disable-send-community extended' => {
    set => 'router bgp #3 ; address-family ipv4 unicast ; no neighbor #5 send-community extended',
    del => 'router bgp #3 ; address-family ipv4 unicast ; neighbor #5 send-community extended',
},

But current CLI doesn't have this is parameter (disable-send-community) for afi v4. Only for ipv6

vyos@r4-roll# set protocols bgp 65001 neighbor 10.0.0.2 address-family ipv4-unicast 
Possible completions:
 > allowas-in   Accept a IPv4-route that contains the local-AS in the as-path
   as-override  AS for routes sent to this neighbor to be the local AS
 > attribute-unchanged
                BGP attributes are sent unchanged (IPv4)
 > capability   Advertise capabilities to this neighbor (IPv4)
 > default-originate
                Send default IPv4-route to this neighbor
 > distribute-list
                Access-list to filter IPv4-route updates to/from this neighbor
 > filter-list  As-path-list to filter IPv4-route updates to/from this neighbor
   maximum-prefix

Afi v6

vyos@r4-roll# set protocols bgp 65001 neighbor 10.0.0.2 address-family ipv6-unicast disable-send-community extended

Vtysh

!
router bgp 65001
 neighbor 10.0.0.2 remote-as 65002
 !
 address-family ipv6 unicast
  neighbor 10.0.0.2 activate
  no neighbor 10.0.0.2 send-community extended
 exit-address-family
!

Details

Difficulty level
Easy (less than an hour)
Version
-
Why the issue appeared?
Other
Is it a breaking change?
Config syntax change (migratable)
Issue type
Bug (incorrect behavior)

Event Timeline

Viacheslav changed the subtype of this task from "Feature Request" to "Bug".Aug 31 2020, 8:41 AM
c-po changed Difficulty level from Unknown (require assessment) to Easy (less than an hour).
c-po changed Why the issue appeared? from Will be filled on close to Other.
c-po changed Is it a breaking change? from Unspecified (possibly destroys the router) to Config syntax change (migratable).

Implemented/fixed for VyOS 1.4

erkin set Issue type to Bug (incorrect behavior).Aug 29 2021, 1:15 PM
erkin removed a subscriber: Active contributors.

Required migration script to set commands to proper AFI.