Page MenuHomeVyOS Platform

Rename FRR daemon restart op-mode commands
Closed, ResolvedPublic

Description

The current command to restart any of the FRR processes is:

cpo@CR1.wueI:~$ restart frr
Possible completions:
  <Enter>       Execute the current command
  bfdd          Restart Bidirectional Forwarding Detection daemon
  bgpd          Restart Border Gateway Protocol daemon
  ospf6d        Restart OSPFv3 daemon
  ospfd         Restart OSPFv2 daemon
  ripd          Restart Routing Information Protocol daemon
  ripngd        Restart RIPng daemon
  staticd       Restart Static Route daemon
  zebra         Restart IP routing manager daemon

From a real-life example:

Two engineers needed 5 minutes to figure its under frr ;) thats why I would line to drop the frr level.

Its less intuitive to have restart frr ospfd or restart frr bgpd compared to restart ospf and restart bgp - we have the same for restart ssh or restart snmp and not restart openssh sshd - we should drop the FRR product name - maybe it will be another routing engine in another release (edited)

I would also drop the d (daemon) suffix so the commands align with the VyOS CLI, else there would a missunderstanding from ospf6d to ospfv3.

As CLI changes are now still fairly easy before launch of VyOS 1.3.0-epa1 I'd implement this in equuleus branch first and then cherry-pick to current

Details

Difficulty level
Unknown (require assessment)
Version
1.3.0-rc5
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Cosmetic issue (typos etc.)

Event Timeline

c-po changed the task status from Open to In progress.Aug 25 2021, 12:35 PM
c-po claimed this task.
c-po triaged this task as High priority.
c-po created this task.
c-po created this object in space S1 VyOS Public.
c-po updated the task description. (Show Details)
c-po updated the task description. (Show Details)
c-po changed Issue type from Unspecified (please specify) to Cosmetic issue (typos etc.).