Page MenuHomeVyOS Platform
Create Task
Maniphest T5179

multi nodes defined in XML are not properly represented as list in get_config_dict()
Closed, ResolvedPublicBUG
Actions

Description

Support for list representation of <multi/> nodes was fixed a very long time back. Meaning when calling get_config_dict() it must always retunr a list even if there's only one element on that <multi/> node.

T5010 brought up a corner case where this does not work.

This can be reproduced by:

set protocols bgp address-family l2vpn-evpn vni 100070 route-target both 1:2
set protocols bgp address-family l2vpn-evpn vni 100070 route-target export 70:10070
set protocols bgp address-family l2vpn-evpn vni 100070 route-target export 20:20
set protocols bgp address-family l2vpn-evpn vni 100070 route-target import 70:10070
set protocols bgp system-as 100

Which will generate a config dict of e.g.:

{'address_family': {'l2vpn_evpn': {'vni': {'100070': {'route_target': {'both': '1:2', 'export': ['70:100070', '20:20'], 'import': '70:100070'}}}}},
 'system_as': '100'}

One can cleary see if export is specified two times -> list, whereas import specified only once -> string (both use the same XML data and are <multi/> nodes. This goes back to the issue in T3234 and seems that the replacement of str -> list is dependent on the nesting depth according to @jestabro

Details

Difficulty level
Normal (likely a few hours)
Version
vyos-1.4-rolling-202304231929-amd64.iso
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Related Objects
Search...

Event Timeline

c-po assigned this task to jestabro.Apr 25 2023, 5:15 AM
c-po triaged this task as High priority.
c-po created this task.
c-po added a parent task: T3234: multi_to_list fails in certain cases, with root cause an element redundancy in XML interface-definitions.
jestabro merged a task: T5178: Fix missed case in multi_to_list conversion.Apr 25 2023, 5:20 AM

Merged T5178 into this one; cf. the description there for background of the issue.

jestabro added a comment.Apr 25 2023, 5:57 AM

PR:
https://github.com/vyos/vyos-1x/pull/1970

jestabro added a comment.Apr 25 2023, 5:59 AM

Test case above produces:

{'address-family': {'l2vpn-evpn': {'vni': {'100070': {'route-target': {'both': ['1:2'],
      'export': ['70:10070', '20:20'],
      'import': ['70:10070']}}}}},
 'system-as': '100'}
pasik added a subscriber: pasik.Apr 25 2023, 7:37 AM
jestabro closed this task as Resolved.Apr 25 2023, 9:08 PM
jestabro moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.