Page MenuHomeVyOS Platform
Create Task
Maniphest T5428

dhcp: client renewal fails when running inside VRF
Closed, ResolvedPublicBUG
Actions

Description

cpo@leaf-02# run show vrf MGMT processes
 2282  sshd

There is no dhclient process running in given VRF. dhclient complains it can not send out packets via the given interface (as it's not bound to that VRF)

Aug 02 20:29:54 dhclient[1686]: send_packet: Network is unreachable
Aug 02 20:29:54 dhclient[1686]: send_packet: please consult README file regarding broadcast address.
Aug 02 20:29:54 dhclient[1686]: dhclient.c:3001: Failed to send 300 byte long packet over fallback interface.

In addition as the /var/lib/dhcp path is spread accross multiple Python files/modules take the opportunity and create a new path in python/vyos/defaults.py named 'isc_dhclient_dir' : '/var/lib/dhcp' which can later be referenced by all the consumers.

Details

Difficulty level
Easy (less than an hour)
Version
1.4-rolling-202308021247
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Related Objects
Search...

Event Timeline

c-po claimed this task.Aug 2 2023, 8:30 PM
c-po triaged this task as High priority.
c-po created this task.
c-po updated the task description. (Show Details)
c-po changed the task status from Open to In progress.Aug 3 2023, 8:23 AM
c-po updated the task description. (Show Details)
pasik added a subscriber: pasik.Aug 3 2023, 10:14 AM
c-po changed the task status from In progress to Needs testing.Aug 4 2023, 6:14 PM

The VRF error applies to DHCPv6, too

c-po added a parent task: T3424: PPPoE IA-PD doesn't work in VRF.Aug 4 2023, 6:15 PM
c-po changed the task status from Needs testing to Backport pending.Aug 5 2023, 8:07 AM
c-po added a project: VyOS 1.3 Equuleus (1.3.3).
c-po moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.
c-po added a comment.Aug 5 2023, 8:10 AM

Bug present in 1.3.3 as well

c-po added a comment.Aug 5 2023, 8:54 PM

PR for 1.3 https://github.com/vyos/vyos-1x/pull/2134

c-po edited projects, added VyOS 1.3 Equuleus (1.3.4); removed VyOS 1.3 Equuleus (1.3.3).Aug 5 2023, 8:55 PM
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.4) board.
c-po added a comment.Aug 17 2023, 11:04 AM

Tested after merging T5476 and now we see a proper DHCP release message

13:01:45.765811 00:50:56:b3:9c:1d > ff:ff:ff:ff:ff:ff, ethertype IPv4 (0x0800), length 342: (tos 0x10, ttl 128, id 0, offset 0, flags [none], proto UDP (17), length 328)
    0.0.0.0.68 > 255.255.255.255.67: [udp sum ok] BOOTP/DHCP, Request from 00:50:56:b3:9c:1d, length 300, xid 0xd4afe335, Flags [none] (0x0000)
          Client-Ethernet-Address 00:50:56:b3:9c:1d
          Vendor-rfc1048 Extensions
            Magic Cookie 0x63825363
            DHCP-Message (53), length 1: Discover
            Hostname (12), length 8: "LR1.wue3"
            Parameter-Request (55), length 7:
              Subnet-Mask (1), BR (28), Default-Gateway (3), Domain-Name-Server (6)
              Classless-Static-Route (121), Domain-Name (15), MTU (26)
13:01:46.775095 00:0d:b9:51:fc:3d > 00:50:56:b3:9c:1d, ethertype IPv4 (0x0800), length 342: (tos 0x10, ttl 128, id 0, offset 0, flags [none], proto UDP (17), length 328)
    172.31.0.254.67 > 172.31.0.172.68: [udp sum ok] BOOTP/DHCP, Reply, length 300, xid 0xd4afe335, Flags [none] (0x0000)
          Your-IP 172.31.0.172
          Client-Ethernet-Address 00:50:56:b3:9c:1d
          Vendor-rfc1048 Extensions
            Magic Cookie 0x63825363
            DHCP-Message (53), length 1: Offer
            Server-ID (54), length 4: 172.31.0.254
            Lease-Time (51), length 4: 85115
            Subnet-Mask (1), length 4: 255.255.255.0
            Default-Gateway (3), length 4: 172.31.0.254
            Domain-Name-Server (6), length 4: 172.31.0.254
            Domain-Name (15), length 9: "mybll.net"
13:01:46.775276 00:50:56:b3:9c:1d > ff:ff:ff:ff:ff:ff, ethertype IPv4 (0x0800), length 342: (tos 0x10, ttl 128, id 0, offset 0, flags [none], proto UDP (17), length 328)
    0.0.0.0.68 > 255.255.255.255.67: [udp sum ok] BOOTP/DHCP, Request from 00:50:56:b3:9c:1d, length 300, xid 0xd4afe335, Flags [none] (0x0000)
          Client-Ethernet-Address 00:50:56:b3:9c:1d
          Vendor-rfc1048 Extensions
            Magic Cookie 0x63825363
            DHCP-Message (53), length 1: Request
            Server-ID (54), length 4: 172.31.0.254
            Requested-IP (50), length 4: 172.31.0.172
            Hostname (12), length 8: "LR1.wue3"
            Parameter-Request (55), length 7:
              Subnet-Mask (1), BR (28), Default-Gateway (3), Domain-Name-Server (6)
              Classless-Static-Route (121), Domain-Name (15), MTU (26)
13:01:46.779746 00:0d:b9:51:fc:3d > 00:50:56:b3:9c:1d, ethertype IPv4 (0x0800), length 342: (tos 0x10, ttl 128, id 0, offset 0, flags [none], proto UDP (17), length 328)
    172.31.0.254.67 > 172.31.0.172.68: [udp sum ok] BOOTP/DHCP, Reply, length 300, xid 0xd4afe335, Flags [none] (0x0000)
          Your-IP 172.31.0.172
          Client-Ethernet-Address 00:50:56:b3:9c:1d
          Vendor-rfc1048 Extensions
            Magic Cookie 0x63825363
            DHCP-Message (53), length 1: ACK
            Server-ID (54), length 4: 172.31.0.254
            Lease-Time (51), length 4: 85114
            Subnet-Mask (1), length 4: 255.255.255.0
            Default-Gateway (3), length 4: 172.31.0.254
            Domain-Name-Server (6), length 4: 172.31.0.254
            Domain-Name (15), length 9: "mybll.net"

Delete CLI config

[email protected]# delete interfaces ethernet eth2 address
[email protected]# delete interfaces ethernet eth2 vrf
[email protected]# commit
13:02:09.820533 00:50:56:b3:9c:1d > 00:0d:b9:51:fc:3d, ethertype IPv4 (0x0800), length 342: (tos 0x0, ttl 64, id 23539, offset 0, flags [DF], proto UDP (17), length 328)
    172.31.0.172.68 > 172.31.0.254.67: [bad udp cksum 0x5b2e -> 0x6b9f!] BOOTP/DHCP, Request from 00:50:56:b3:9c:1d, length 300, xid 0x7ff7c962, Flags [none] (0x0000)
          Client-IP 172.31.0.172
          Client-Ethernet-Address 00:50:56:b3:9c:1d
          Vendor-rfc1048 Extensions
            Magic Cookie 0x63825363
            DHCP-Message (53), length 1: Release
            Server-ID (54), length 4: 172.31.0.254
            Hostname (12), length 8: "LR1.wue3"
c-po moved this task from Finished to Backlog on the VyOS 1.3 Equuleus (1.3.4) board.Aug 17 2023, 11:11 AM
c-po mentioned this in T5492: CLI node priority is not inversed on node deletion.Aug 18 2023, 12:00 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.5); removed VyOS 1.3 Equuleus (1.3.4).Aug 25 2023, 9:24 PM
syncer moved this task from Need Triage to Backlog on the VyOS 1.3 Equuleus (1.3.5) board.
c-po added a comment.Sep 1 2023, 6:31 AM

PR for 1.3 https://github.com/vyos/vyos-1x/pull/2191

c-po closed this task as Resolved.Sep 5 2023, 7:20 PM
c-po edited projects, added VyOS 1.3 Equuleus (1.3.4); removed VyOS 1.3 Equuleus (1.3.5).
c-po moved this task from Backlog to Finished on the VyOS 1.3 Equuleus (1.3.4) board.
dmbaturin mentioned this in 1.3.4.Sep 14 2023, 1:07 PM
c-po merged a task: T4453: dhclient fails to renew DHCP lease with VRF.Mar 28 2024, 6:35 AM
c-po added subscribers: marekm, hsw0, NeilHanlon.