Page MenuHomeVyOS Platform

Minor fixes to configtree render
Closed, ResolvedPublicFEATURE REQUEST

Description

The configtree render function includes empty braces following a valueless node (example below): this is apparent in 'compare', and would be apparent in the saved config file after T4292 without the proposed fix. The suggested change to the render function also fixes an issue with indenting in tag nodes. The result is formatting that will be similar to that of the legacy code, as had been requested.

Current:

vyos@vyos# set service ssh disable-host-validation 
vyos@vyos# compare
[service ssh]
+ disable-host-validation { }

Proposed:

vyos@vyos# set service ssh disable-host-validation 
vyos@vyos# compare
[service ssh]
+ disable-host-validation

Details

Difficulty level
Normal (likely a few hours)
Version
vyos-1.4
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Improvement (missing useful functionality)