Page MenuHomeVyOS Platform
Create Task
Maniphest T5902

http: remove virtual-host configuration in webserver
Closed, ResolvedPublicBUG
Actions

Description

As discussed with @jestabro both of us have not seen the adoption of the https virtual-host CLI option.

What it did?

  • Create multiple webservers each listening on a different IP/Port (but in the same VRF)
  • All webservers shared one common documentroot
  • All webservers shared the same SSL certificates
  • All webservers could have had individual allow-client configurations
  • API could be enabled for a particular virtual-host but was always enabled on the default host

This configuration tried to provide a full webserver via the CLI but VyOS is a router and the Webserver is there for an API or to serve files for a local-ui.

Changes

  • Remove support for virtual-hosts as it's an incomplete and thus mostly useless "thing"
  • Migrate all allow-client statements to one top-level allow statement

Details

Difficulty level
Hard (possibly days)
Version
1.4.0-rc1
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Config syntax change (migratable)
Issue type
Feature/functionality removal

Related Objects
Search...

Event Timeline

c-po changed the task status from Open to In progress.Jan 6 2024, 10:02 AM
c-po claimed this task.
c-po created this task.
Apachez added a subscriber: Apachez.Jan 6 2024, 10:50 AM

Having support for vhost is handy when you dont want just to blindly share a single documentroot but have the ability to use multiple at a single host.

For example having http://crl.example.com and http://update.example.com end up at two different documentroots.

c-po moved this task from Need Triage to In Progress on the VyOS 1.4 Sagitta board.Jan 6 2024, 7:58 PM
c-po added a comment.Jan 8 2024, 8:17 PM

Well, the webserver is for an API - if you wan't to server files you can either use the default document root, or spawn a container. We should focus on packet pushing and administration.

c-po moved this task from Need Triage to Finished on the VyOS 1.5 Circinus board.Jan 9 2024, 6:48 AM
c-po closed this task as Resolved.Jan 10 2024, 5:57 PM
c-po triaged this task as High priority.
c-po moved this task from In Progress to Finished on the VyOS 1.4 Sagitta board.
Zen3515 added a subscriber: Zen3515.Jan 13 2024, 12:00 PM

Hello, this task has a bug. Do I open a new task or comment here?

Essentially, the migration script migrates the wrong key, it should be port not listen-port

https://github.com/vyos/vyos-1x/blob/864524ba86b0a4d57ab64d6e9398c3fd5eb2fce4/interface-definitions/service_https.xml.in#L45
https://github.com/vyos/vyos-1x/blob/d0d3071e99eb65edb888c26ef2fdc9e038438887/src/migration-scripts/https/5-to-6#L82

c-po added a comment.Feb 9 2024, 7:33 AM

@Zen3515 thanks for the information.

https://github.com/vyos/vyos-1x/pull/2975