Fully supportive of this. My ISP (Swisscom) require the setting of DHCP option 60 (vendor-class-identifier) in order for an IP to be granted to xDSL lines.

Why plural and not singular dhcp-option?

It was resolved with https://github.com/vyos/vyatta-cfg-quagga/pull/27/files#diff-2d07759ce6afdf217934849f11a824f6

I was looking on this issue. Please find below a description of what I think is the root cause for this issue:

I agree with @aibanez
In addition, sometimes it works (but only a very few) while almost always it crashes at startup and interfaces are messed.
Do you guys have any clue/suggestion or any other further test that can be done?

Try: https://github.com/vyos/vyatta-cfg-quagga/pull/27/commits/8c741da0691cb392a86f249b61c3686a034f908a

Hi guys,

from Slack

can it be that the fix for T1243 is broken? I can understand that local-as can't be the same like remote-as if router-as diff from local-as but the patch forbit to set remote-as to the same like router-as that will break ibgp

I met this issue before. But I can save firewall group to a txt then use ipset to load the firewall groups when system boot. It works well. Vyos boot quickly and firewall policy updated well.

Thanks for testing.

@hagbard Looks good:

8472 is the default port used by the Kernel, and thus fully backwards compatible with older installations. 4789 is the IANA assigned value which you could configure using remote-port.

I'll check this tonight.

the commit success now in the latest rolling.

@sentania Can you please test with the latest rolling, the issue should have been fixed now.

@rob Fix will be in next rolling release

@dmbaturin merge if it's not already there

Test with latest vyos-1.2.0-rolling+201905120337-amd64.iso success.
Thank you.

Unfortunately a build of vyatta-webproxy was not triggered on push to GitHub. Next rolling will have it!

Test with 1.2.0-rolling+201905110337

successfully tested on:
Version: VyOS 1.2.0-rolling+201905081347
Built by: [email protected]
Built on: Wed 08 May 2019 13:47 UTC
Build ID: 7093c43d-6ea7-45c9-a7c5-3fdf07c0ebc7

Please test with next rolling release if this problem is fixed so we can close this issue if this is ok for you. Whitlist issues should be separate ones. Thanks for assistance.

backported to crux

Fixed in commits:

Now it seems to report guest info succesfully:

Tested in 1.2.0-rolling+201904250337, everything looks great now, no warnings arise and required config is in place, so I'll wait for 1.2.2 to get the fixed version of ethtool.
Thanks for your efforts, great work!

@zsdc Can you please test?

@zsdc Can you please share some config data or clarify what you mean? thx

Fix, should be in the next rolling release:
https://github.com/vyos/vyatta-cfg-quagga/commit/41df1579f6ca3e5a1618ee85bbb337011148f1ef

@zsdc is local-as required anyway? Isn't it always the same as the router-as?

@c-po thanks for that. I changed my configs from postconfig script to new config syntax