Page MenuHomeVyOS Platform
Feed All Stories

Apr 8 2020

jjakob triaged T2249: Interface definitions must always have the correct 'type:' set as Low priority.
Apr 8 2020, 9:04 PM · VyOS 1.3 Equuleus (1.3.8)
tjh added a comment to T2248: PPPoE Broken in Latest 1.3 Rolling (1.3-rolling-202004070629).

Please find below, with some comments redacted.

Apr 8 2020, 8:50 PM · VyOS 1.3 Equuleus (1.3.0)
c-po added a comment to T2248: PPPoE Broken in Latest 1.3 Rolling (1.3-rolling-202004070629).

I can't reproduce it with the code in the rolling image that will be available by tomorrow.

Apr 8 2020, 8:49 PM · VyOS 1.3 Equuleus (1.3.0)
c-po added a project to T2248: PPPoE Broken in Latest 1.3 Rolling (1.3-rolling-202004070629): VyOS 1.3 Equuleus.
Apr 8 2020, 8:45 PM · VyOS 1.3 Equuleus (1.3.0)
c-po added a comment to T2248: PPPoE Broken in Latest 1.3 Rolling (1.3-rolling-202004070629).

Can you please share your configuration on the pppoe interface with us?

Apr 8 2020, 8:37 PM · VyOS 1.3 Equuleus (1.3.0)
c-po claimed T2248: PPPoE Broken in Latest 1.3 Rolling (1.3-rolling-202004070629).
Apr 8 2020, 8:36 PM · VyOS 1.3 Equuleus (1.3.0)
tjh updated tjh.
Apr 8 2020, 8:16 PM
tjh added a comment to T2248: PPPoE Broken in Latest 1.3 Rolling (1.3-rolling-202004070629).

The only major differences I've noticed are the kernel versions:

Apr 8 2020, 8:13 PM · VyOS 1.3 Equuleus (1.3.0)
tjh created T2248: PPPoE Broken in Latest 1.3 Rolling (1.3-rolling-202004070629).
Apr 8 2020, 8:11 PM · VyOS 1.3 Equuleus (1.3.0)
c-po reassigned T2091: swanctl.conf file is not generated properly if more than one IPsec profile is used from c-po to Unknown Object (User).
Apr 8 2020, 7:59 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.2 Crux (VyOS 1.2.6)
c-po updated subscribers of T2091: swanctl.conf file is not generated properly if more than one IPsec profile is used.

Re-assigning to @Dmitry after checking with him as he's more experienced here.

Apr 8 2020, 7:59 PM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.2 Crux (VyOS 1.2.6)
c-po closed T2240: Support for bind vif-c interfaces into VRFs as Resolved.
Apr 8 2020, 7:54 PM · VyOS 1.3 Equuleus (1.3.0)
c-po added a comment to T2172: Enable conf VXLAN without remote address.

Where do I get the local address from? Can you share your complete config? Maybe we need source-address or something similar in CLI.

Apr 8 2020, 7:35 PM · VyOS 1.3 Equuleus (1.3.0)
c-po added a comment to T2232: Prevent deletion of bridge member interfaces.

Yes - there are some parts which make use of this bad practice (mostly introduced by me), cleanup required.

Apr 8 2020, 7:34 PM · Restricted Project, VyOS 1.5 Circinus
c-po updated the task description for T2232: Prevent deletion of bridge member interfaces.
Apr 8 2020, 7:33 PM · Restricted Project, VyOS 1.5 Circinus
c-po closed T2244: WireGuard: cleanup Python implementation and reduce amount of boilerplate code, a subtask of T2232: Prevent deletion of bridge member interfaces, as Resolved.
Apr 8 2020, 7:32 PM · Restricted Project, VyOS 1.5 Circinus
c-po closed T2244: WireGuard: cleanup Python implementation and reduce amount of boilerplate code as Resolved.
Apr 8 2020, 7:32 PM · VyOS 1.3 Equuleus (1.3.0)
c-po closed T2247: WireGuard: add VRF support as Resolved.
Apr 8 2020, 7:31 PM · VyOS 1.3 Equuleus (1.3.0)
c-po changed the status of T2247: WireGuard: add VRF support from Open to In progress.
Apr 8 2020, 7:08 PM · VyOS 1.3 Equuleus (1.3.0)
c-po created T2247: WireGuard: add VRF support.
Apr 8 2020, 7:08 PM · VyOS 1.3 Equuleus (1.3.0)
c-po renamed T2244: WireGuard: cleanup Python implementation and reduce amount of boilerplate code from WireGuard: cleanup Python implementation and reduce amount of boiler plate code to WireGuard: cleanup Python implementation and reduce amount of boilerplate code.
Apr 8 2020, 6:59 PM · VyOS 1.3 Equuleus (1.3.0)
c-po closed T2246: LLDP op-mode error as Resolved.
Apr 8 2020, 6:37 PM · VyOS 1.3 Equuleus (1.3.0)
c-po claimed T2246: LLDP op-mode error.
Apr 8 2020, 6:22 PM · VyOS 1.3 Equuleus (1.3.0)
Viacheslav created T2246: LLDP op-mode error.
Apr 8 2020, 5:29 PM · VyOS 1.3 Equuleus (1.3.0)
zsdc changed the status of T2245: Need to create a common logging module for Python scripts from Open to In progress.
Apr 8 2020, 5:21 PM · VyOS 1.5 Circinus
zsdc created T2245: Need to create a common logging module for Python scripts.
Apr 8 2020, 5:20 PM · VyOS 1.5 Circinus
thomas-mangin added a comment to T2171: Unify creation and manipulation of interfaces.

There is an issue with storing the state of the interface and then applying it in bulk. For some interface we want to admin it down before performing change and then bringing it back up.
If we store this then only the change and the up command will be applied, this is not going to work.

Apr 8 2020, 4:56 PM · VyOS 1.4 Sagitta
thomas-mangin added a comment to T2204: Support tunnel source-interface.

@cpo should another task be created to make sure we exclude the interfaces themself from source-interface (s) ?

Apr 8 2020, 4:50 PM · VyOS 1.3 Equuleus (1.3.0)
thomas-mangin closed T2242: Remove import * from the code as Resolved.
Apr 8 2020, 4:48 PM
thomas-mangin added a comment to T2242: Remove import * from the code.

https://github.com/vyos/vyos-1x/pull/316

Apr 8 2020, 4:48 PM
thomas-mangin closed T2186: Provide more information to the user when a traceback is reported to the user as Resolved.
Apr 8 2020, 4:06 PM · VyOS 1.3 Equuleus (1.3.0)
thomas-mangin added a comment to T2186: Provide more information to the user when a traceback is reported to the user.

https://github.com/vyos/vyos-1x/pull/314

Apr 8 2020, 4:04 PM · VyOS 1.3 Equuleus (1.3.0)
Viacheslav claimed T2201: Rewrite protocol BGP [op-mode] to new XML/Python style.
Apr 8 2020, 3:50 PM · VyOS 1.3 Equuleus (1.3.0)
c-po added a subtask for T2232: Prevent deletion of bridge member interfaces: T2244: WireGuard: cleanup Python implementation and reduce amount of boilerplate code.
Apr 8 2020, 3:48 PM · Restricted Project, VyOS 1.5 Circinus
c-po added a parent task for T2244: WireGuard: cleanup Python implementation and reduce amount of boilerplate code: T2232: Prevent deletion of bridge member interfaces.
Apr 8 2020, 3:48 PM · VyOS 1.3 Equuleus (1.3.0)
c-po changed the status of T2244: WireGuard: cleanup Python implementation and reduce amount of boilerplate code from Open to In progress.
Apr 8 2020, 3:48 PM · VyOS 1.3 Equuleus (1.3.0)
Viacheslav updated the task description for T2201: Rewrite protocol BGP [op-mode] to new XML/Python style.
Apr 8 2020, 3:47 PM · VyOS 1.3 Equuleus (1.3.0)
c-po created T2244: WireGuard: cleanup Python implementation and reduce amount of boilerplate code.
Apr 8 2020, 3:47 PM · VyOS 1.3 Equuleus (1.3.0)
c-po created T2243: Bridge interface fails if member is VXLAN interface with VTI underlay.
Apr 8 2020, 3:40 PM · VyOS 1.3 Equuleus (1.3.8)
thomas-mangin claimed T2242: Remove import * from the code.
Apr 8 2020, 3:39 PM
zsdc changed the status of T1820: VRRP transition scripts for sync-groups are not supported in VyOS (anymore) from Open to Needs testing.

Hello, @adestis!
Support of transition-scripts was added to sync-groups in a rolling version.

Apr 8 2020, 3:35 PM · VyOS 1.3 Equuleus (1.3.0)
thomas-mangin created T2242: Remove import * from the code.
Apr 8 2020, 3:24 PM
zsdc claimed T2189: Adding a large port-range will take ~ 20 minutes to commit.

I have investigated this a bit. Most operations for ports are doing one-by-one. Deleting as I see is always done in this way. Adding a range is done by a single command, but checking ports are doing one-by-one.
If we skip/change mentioned checking for adding ports, this should decrease initial commit time. But when we try to change/delete ports, the issue will back.
I think that there should be better to reimplement the whole firewall group section in Python, instead of fixing this logic now.

Apr 8 2020, 2:21 PM · VyOS 1.3 Equuleus (1.3.3)
Unknown Object (User) changed the status of T2236: DMVPN broken after tunnel rewrite to XML/Python from Open to Needs testing.
Apr 8 2020, 1:37 PM · VyOS 1.3 Equuleus (1.3.0)
Unknown Object (User) added a comment to T2236: DMVPN broken after tunnel rewrite to XML/Python.

PR for this task https://github.com/vyos/vyos-1x/pull/313

Apr 8 2020, 1:37 PM · VyOS 1.3 Equuleus (1.3.0)
Viacheslav updated the task description for T2201: Rewrite protocol BGP [op-mode] to new XML/Python style.
Apr 8 2020, 1:20 PM · VyOS 1.3 Equuleus (1.3.0)
thomas-mangin added a comment to T2186: Provide more information to the user when a traceback is reported to the user.

thanks to @runborg .. my own initial attempt to syslog failed (facility level ??)
This works

import logging
import logging.handlers
my_logger = logging.getLogger('MyLogger')  # logger is singleton
my_logger.setLevel(logging.DEBUG)
handler = logging.handlers.SysLogHandler(address='/dev/log', facility="auth")
my_logger.addHandler(handler)
my_logger.critical('this is critical')
Apr 8 2020, 12:07 PM · VyOS 1.3 Equuleus (1.3.0)
thomas-mangin added a comment to T2186: Provide more information to the user when a traceback is reported to the user.
from shlex import quote
def systemd(self, level, message):
    msg = quote(message)
    run(f'echo {msg} | systemd-cat -p {self.level}')
Apr 8 2020, 11:53 AM · VyOS 1.3 Equuleus (1.3.0)
jjakob updated the task description for T2241: Changing settings on an interface causes it to fall out of bridge.
Apr 8 2020, 11:52 AM · VyOS 1.3 Equuleus (1.3.0)
jjakob triaged T2241: Changing settings on an interface causes it to fall out of bridge as Urgent! priority.
Apr 8 2020, 11:42 AM · VyOS 1.3 Equuleus (1.3.0)
jjakob added a comment to T2186: Provide more information to the user when a traceback is reported to the user.

Personally I'd use systemd-journald which I think provides the same logging facilities as rsyslog used to, but vyos still runs both. IMO the logging section is a mess and would need a complete rewrite to journal.

Apr 8 2020, 11:31 AM · VyOS 1.3 Equuleus (1.3.0)
thomas-mangin added a comment to T2186: Provide more information to the user when a traceback is reported to the user.
# sudo lsof  | grep dev-log
I am officially daft .. I thought it was not running !
Apr 8 2020, 11:27 AM · VyOS 1.3 Equuleus (1.3.0)
thomas-mangin updated subscribers of T2186: Provide more information to the user when a traceback is reported to the user.

@dmbaturin I was aked on slack to report the information via syslog. However the syslog server is not listening on on UDP port 514 on localhost. How would you like to proceed ?
should it be opened (I am not sure where this should be configured) or should the log be written on the drive using the python logging module (as I currently have implemented).

Apr 8 2020, 10:44 AM · VyOS 1.3 Equuleus (1.3.0)
thomas-mangin updated the task description for T2057: Generalised Interface configuration.
Apr 8 2020, 10:42 AM · VyOS 1.3 Equuleus (1.3.0)
thomas-mangin added a comment to T2232: Prevent deletion of bridge member interfaces.

@cpo AFAIU the patches are not right as the code making use of Config() in the verify() section and AFAIU this is against the separation between get_config()

Apr 8 2020, 10:28 AM · Restricted Project, VyOS 1.5 Circinus
Viacheslav reopened T2172: Enable conf VXLAN without remote address, a subtask of T1315: Allow BGP to use address-family l2vpn evpn, as Open.
Apr 8 2020, 10:09 AM · VyOS 1.3 Equuleus (1.3.0)
Viacheslav reopened T2172: Enable conf VXLAN without remote address as "Open".
Apr 8 2020, 10:09 AM · VyOS 1.3 Equuleus (1.3.0)
zsdc changed the status of T723: Add support for first boot or installation time saved config modification from Open to Needs testing.

Already possible via Cloud-init. For different environments may be required differently tuned images (data sources, additional tools like guest agents, etc.).

Apr 8 2020, 10:02 AM · VyOS 1.3 Equuleus (1.3.0-epa1)
fetzerms added a comment to T2203: http api: "Failed to generate committed config" .

I think I can pinpoint it down to the mesh generation using wireguard. Please see the logs of two failed nodes attached. I dont find older rotations of the log file. Thats all I have.

Apr 8 2020, 5:07 AM
jestabro closed T2160: Allow restricting HTTP API to specific virtual hosts as Resolved.
Apr 8 2020, 2:58 AM · VyOS 1.3 Equuleus (1.3.0)
jestabro reopened T2160: Allow restricting HTTP API to specific virtual hosts as "Open".
Apr 8 2020, 2:56 AM · VyOS 1.3 Equuleus (1.3.0)
syncer changed the status of T2239: build-vmware-image script ignores the predefined file path, uses the environment variable unconditionally. from Open to Confirmed.
Apr 8 2020, 1:09 AM · VyOS 1.3 Equuleus (1.3.0)
kroy added a comment to T2239: build-vmware-image script ignores the predefined file path, uses the environment variable unconditionally..

Looks good. I don't have merge access but this definitely is a fix to an oversight in the build.

Apr 8 2020, 1:07 AM · VyOS 1.3 Equuleus (1.3.0)

Apr 7 2020

syncer changed the status of T2237: l2tp, pptp, pppoe wrong chap-secrets file from Needs testing to Backport candidate.
Apr 7 2020, 11:08 PM · VyOS 1.3 Equuleus (1.3.0)
syncer added a project to T2237: l2tp, pptp, pppoe wrong chap-secrets file: VyOS 1.3 Equuleus.
Apr 7 2020, 11:07 PM · VyOS 1.3 Equuleus (1.3.0)
syncer added a comment to T2239: build-vmware-image script ignores the predefined file path, uses the environment variable unconditionally..

@chrismarget we autogenerate list of resolved issues for releases
so tasks names should be with more context

Apr 7 2020, 10:37 PM · VyOS 1.3 Equuleus (1.3.0)
syncer renamed T2239: build-vmware-image script ignores the predefined file path, uses the environment variable unconditionally. from Review/Merge(?) PR #98 in vyos-build to build-vmware-image script ignores the predefined file path, uses the environment variable unconditionally..
Apr 7 2020, 10:36 PM · VyOS 1.3 Equuleus (1.3.0)
syncer assigned T2240: Support for bind vif-c interfaces into VRFs to c-po.
Apr 7 2020, 10:35 PM · VyOS 1.3 Equuleus (1.3.0)
syncer added a comment to T2239: build-vmware-image script ignores the predefined file path, uses the environment variable unconditionally..

Not really, just make sure you include VyOS 1.3 project so we can track what can be backported
you will need to adjust your PR message to include task number T2239

Apr 7 2020, 10:34 PM · VyOS 1.3 Equuleus (1.3.0)
chrismarget added a comment to T2239: build-vmware-image script ignores the predefined file path, uses the environment variable unconditionally..

Did I do the wrong thing by tagging this for vyos-build?

Apr 7 2020, 10:32 PM · VyOS 1.3 Equuleus (1.3.0)
JB_VCC created T2240: Support for bind vif-c interfaces into VRFs.
Apr 7 2020, 10:30 PM · VyOS 1.3 Equuleus (1.3.0)
jestabro added a comment to T2203: http api: "Failed to generate committed config" .

@fetzerms I was mistaken: cfg-stdout.log is logrotated, but not removed on boot, and this is useful info. When you are able to reproduce, please share. I believe the corner case I am seeing is distinct but related to what you are seeing. Thanks.

Apr 7 2020, 9:39 PM
syncer assigned T2239: build-vmware-image script ignores the predefined file path, uses the environment variable unconditionally. to kroy.
Apr 7 2020, 9:34 PM · VyOS 1.3 Equuleus (1.3.0)
chrismarget triaged T2239: build-vmware-image script ignores the predefined file path, uses the environment variable unconditionally. as Normal priority.
Apr 7 2020, 9:29 PM · VyOS 1.3 Equuleus (1.3.0)
c-po updated the task description for T2232: Prevent deletion of bridge member interfaces.
Apr 7 2020, 8:03 PM · Restricted Project, VyOS 1.5 Circinus
Unknown Object (User) closed T1114: VyOS 1.2 tftp issue, NAT client could not boot via tftp server, same setup on VyOS 1.1.8 works fine as Resolved.

The automatic helper assignment is enabled in both the LTS and the current rolling releases. The only thing that is needed to make the TFTP working is to allow the udp/69 and "related" traffic.

Apr 7 2020, 8:02 PM
c-po updated the task description for T2232: Prevent deletion of bridge member interfaces.
Apr 7 2020, 7:54 PM · Restricted Project, VyOS 1.5 Circinus
c-po updated the task description for T2232: Prevent deletion of bridge member interfaces.
Apr 7 2020, 7:54 PM · Restricted Project, VyOS 1.5 Circinus
c-po updated the task description for T2238: After re-writing list_interfaces.py to use Interfaces() pseudo-ethernet is missing.
Apr 7 2020, 7:51 PM · VyOS 1.3 Equuleus (1.3.0)
c-po assigned T2238: After re-writing list_interfaces.py to use Interfaces() pseudo-ethernet is missing to thomas-mangin.
Apr 7 2020, 7:50 PM · VyOS 1.3 Equuleus (1.3.0)
c-po created T2238: After re-writing list_interfaces.py to use Interfaces() pseudo-ethernet is missing.
Apr 7 2020, 7:50 PM · VyOS 1.3 Equuleus (1.3.0)
c-po updated the task description for T2232: Prevent deletion of bridge member interfaces.
Apr 7 2020, 7:42 PM · Restricted Project, VyOS 1.5 Circinus
c-po updated the task description for T2232: Prevent deletion of bridge member interfaces.
Apr 7 2020, 7:32 PM · Restricted Project, VyOS 1.5 Circinus
c-po renamed T2232: Prevent deletion of bridge member interfaces from l2tpv3 interface can be deleted while it is still assigned to a bridge to Prevent deletion of bridge member interfaces.
Apr 7 2020, 6:45 PM · Restricted Project, VyOS 1.5 Circinus
Unknown Object (User) closed T1095: Connection tracking NAT / FIREWALL as Resolved.

The automatic helper assignment is enabled in both the LTS and the current rolling releases. The only thing that is needed to make the FTP working is to allow the tcp/21, "related" and "established" traffic.

Apr 7 2020, 6:28 PM
thomas-mangin closed T2190: Instantiating Interfaces without risk of creation as Resolved.
Apr 7 2020, 3:02 PM
thomas-mangin claimed T2190: Instantiating Interfaces without risk of creation.
Apr 7 2020, 3:02 PM
thomas-mangin closed T2226: unify all the ways commands are run as Resolved.
Apr 7 2020, 3:01 PM
hagbard changed the status of T2237: l2tp, pptp, pppoe wrong chap-secrets file from In progress to Needs testing.

merged.

Apr 7 2020, 2:05 PM · VyOS 1.3 Equuleus (1.3.0)
Unknown Object (User) renamed T2237: l2tp, pptp, pppoe wrong chap-secrets file from l2tp wrong chap-secrets file to l2tp, pptp, pppoe wrong chap-secrets file.
Apr 7 2020, 1:24 PM · VyOS 1.3 Equuleus (1.3.0)
Unknown Object (User) changed the subtype of T2237: l2tp, pptp, pppoe wrong chap-secrets file from "Task" to "Bug".
Apr 7 2020, 10:29 AM · VyOS 1.3 Equuleus (1.3.0)
Unknown Object (User) changed the status of T2237: l2tp, pptp, pppoe wrong chap-secrets file from Open to In progress.
Apr 7 2020, 10:29 AM · VyOS 1.3 Equuleus (1.3.0)

Apr 6 2020

Unknown Object (User) updated subscribers of T2236: DMVPN broken after tunnel rewrite to XML/Python.

@UnicronNL

vyos@R3# run show version all | match strongswan
ii  strongswan                       5.7.2-1                             all          IPsec VPN solution metapackage

But in this case, we have an issue with command

vyos@R3# sudo ip link add tun0 type gretap local 0.0.0.0
RTNETLINK answers: File exists

In old scripts, tunnels were created by following commands

ip tunnel add tun0 local 0.0.0.0 mode gre key 1 ttl 255 tos inherit
ip link set tun0 multicast on allmulticast on up
ip addr add 10.0.0.4/24 broadcast + dev tun0
ip tunnel cha tun0 local 0.0.0.0
Apr 6 2020, 10:12 PM · VyOS 1.3 Equuleus (1.3.0)
UnicronNL added a comment to T2236: DMVPN broken after tunnel rewrite to XML/Python.

@Dmitry @c-po is this an other version of strongswan? or is this the strongswan with dmvpn pathes in from vyos repo?

Apr 6 2020, 10:07 PM · VyOS 1.3 Equuleus (1.3.0)
Unknown Object (User) added a comment to T2236: DMVPN broken after tunnel rewrite to XML/Python.

The main reason for this issue - we can't create properly tunnel

set interfaces tunnel tun0 address 10.0.0.3/24
set interfaces tunnel tun0 encapsulation gre
set interfaces tunnel tun0 local-ip 0.0.0.0
set interfaces tunnel tun0 multicast enable
set interfaces tunnel tun0 parameters ip key 1
Apr 6 2020, 9:52 PM · VyOS 1.3 Equuleus (1.3.0)
jestabro added a comment to T2203: http api: "Failed to generate committed config" .

@fetzerms I am able to reproduce this, in a manner that's not completely clean, but which will allow me to investigate further. Feel free to add any other details you run across; thanks.

Apr 6 2020, 9:36 PM
Unknown Object (User) claimed T2236: DMVPN broken after tunnel rewrite to XML/Python.

@c-po let me reproduce this locally, I will find an answer.

Apr 6 2020, 8:31 PM · VyOS 1.3 Equuleus (1.3.0)
c-po updated subscribers of T2236: DMVPN broken after tunnel rewrite to XML/Python.

@Dmitry maybe you have an idea why?

Apr 6 2020, 6:54 PM · VyOS 1.3 Equuleus (1.3.0)
c-po triaged T2236: DMVPN broken after tunnel rewrite to XML/Python as High priority.
Apr 6 2020, 6:45 PM · VyOS 1.3 Equuleus (1.3.0)
c-po created T2236: DMVPN broken after tunnel rewrite to XML/Python.
Apr 6 2020, 6:44 PM · VyOS 1.3 Equuleus (1.3.0)