Page MenuHomeVyOS Platform

thomas-mangin (Thomas Mangin)
User

Projects

User Details

User Since
Nov 12 2019, 5:38 PM (29 w, 1 d)

Recent Activity

Yesterday

thomas-mangin added a comment to T2522: Python CLI.

It should not be too hard to convert the current parser to read.
https://gist.github.com/thomas-mangin/17a450a3e26a4cc41902475c0a1dfe5f

Tue, Jun 2, 11:32 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2522: Python CLI.

@jjakob you are right, there is no shell integration and this is using the python promt-toolkit library to handle input/output.

Tue, Jun 2, 8:10 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2539: Issues with parsing ip range for source nat translation address.

Thank you for reporting this issue, it looks like that parser allows ranges of IP address (IP hyphen IP) but the parser does not. You could get around using CIDR notation but this indeed need looking into.

Tue, Jun 2, 7:44 PM · VyConf
thomas-mangin added a comment to T2542: OpenVPN loose config.

should help to go further in the testing, but it is still failing on set_state but I do not know why it should be done if the interface is managed by openvpn. The relevant code is:

Tue, Jun 2, 7:22 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2522: Python CLI.

As a side note, if there is a need to migrate between backends, it would be possible to change the code to have an option to indicate which storage should be used and allow loading from one, saving to another as long as the XML schema is the same.

Tue, Jun 2, 3:15 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2522: Python CLI.

I see the POC as complete and conclusive, it would only make sense to spend more time on things once this is done (or to add support for control via HTTP/API).

Tue, Jun 2, 3:12 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2522: Python CLI.

Configuring 100 dummy interfaces (no thread)

real	0m 4.60s
user	0m 2.03s
sys	0m 2.01s
Tue, Jun 2, 2:10 PM · VyOS 1.3 Equuleus

Mon, Jun 1

thomas-mangin added a comment to T2418: Interfaces completion (list_interfaces.py) is slow.

Thank you for this long answer @jjakob. I want to demonstrate that a full python solution can provide the performance we need. I appreciate that changing the Vyatta code need to be done carefully with many consideration about backward compatibility. What I am doing is surely 1.4 material. However I do not believe this is as hard to achieve as everyone may think, and as working code is the best way to discuss code design, that is what I am doing.

Mon, Jun 1, 12:34 AM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2522: Python CLI.

The cli is mostly functional. I am able to validate the data as it is typed in conf mode (the CLI has both completion and validation working), as soon as delete and show (the current show is "show configuration commands") are implemented, it will be mostly usable. The code can already load a configuration from file, allow some "set" edit and then allow the use of save (the config format is a number of "set" commands, one per line), respect the initialisation order of the XML.

Mon, Jun 1, 12:29 AM · VyOS 1.3 Equuleus

Sun, May 31

thomas-mangin added a comment to T2088: Increased boot time from 1.2.4 -> 1.3 rolling by 100%.

I used @runar code on my branch working on T2522 .. Configuring 100 dummy interface went from 42 to 8 seconds.

Sun, May 31, 11:56 PM · VyOS 1.3 Equuleus

Sat, May 30

thomas-mangin added a comment to T2418: Interfaces completion (list_interfaces.py) is slow.
vyos@vyos# diff -u /usr/libexec/vyos/completion/list_interfaces.py list_interfaces.py
--- /usr/libexec/vyos/completion/list_interfaces.py	2020-03-21 19:47:22.000000000 +0000
+++ list_interfaces.py	2020-05-30 18:45:30.564000000 +0000
@@ -39,4 +39,7 @@
     print(" ".join([intf for intf in matching("bondable") if '.' not in intf]))
Sat, May 30, 6:08 PM · VyOS 1.3 Equuleus
thomas-mangin updated subscribers of T2522: Python CLI.

I just had a look at VyConf and it is excellent, I fear that no one but @dmbaturin can maintain participate to it.
Also, VyConf will still need to fork all the python code and unless we have a resolution to T2088 - I am not sure what the best path forward will be

Sat, May 30, 5:38 PM · VyOS 1.3 Equuleus
thomas-mangin updated subscribers of T2418: Interfaces completion (list_interfaces.py) is slow.

I tried to get a flamegraph showing what I was wanting to say but .. do not look very clear :-(

Sat, May 30, 3:45 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2418: Interfaces completion (list_interfaces.py) is slow.

Sat, May 30, 3:30 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2500: vyos-build scripts/build-packages builds vyos-1x with version 0.0-no.git.tag.

I believe it was git pull —tags which fixed it for me ..

Sat, May 30, 1:53 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2436: equuleus: Testing: vyos-1x: syntax checking python scripts in PR.

Many scripts also so do implement if name == “main

Sat, May 30, 1:49 PM

Tue, May 26

thomas-mangin added a comment to T2425: Rewrite policy prefix-list to XML/Python style.

Also related to T2088

Tue, May 26, 2:42 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2494: systemd dependencies issues.

https://github.com/vyos/vyos-1x/pull/423

Tue, May 26, 2:24 PM · VyOS 1.3 Equuleus
thomas-mangin updated the task description for T2522: Python CLI.
Tue, May 26, 2:03 PM · VyOS 1.3 Equuleus
thomas-mangin claimed T2522: Python CLI.
Tue, May 26, 1:55 PM · VyOS 1.3 Equuleus
thomas-mangin created T2522: Python CLI.
Tue, May 26, 1:54 PM · VyOS 1.3 Equuleus

Sun, May 24

thomas-mangin added a comment to T2501: Cannot recover from failed boot config load.

The called code can return 3 - in that case in that case _run should return an empty string

Sun, May 24, 9:51 AM · VyOS 1.3 Equuleus

Sat, May 23

thomas-mangin added a comment to T2457: IPv6 ping by address not working.
diff --git a/src/op_mode/ping.py b/src/op_mode/ping.py
index 45b06aa9..f723933b 100644
--- a/src/op_mode/ping.py
+++ b/src/op_mode/ping.py
@@ -210,7 +210,7 @@ if __name__ == '__main__':
     try:
         ip = socket.gethostbyname(host)
     except socket.gaierror:
-        sys.exit(f'ping: Unknown host: {host}')
+        ip = host
Sat, May 23, 5:34 PM
thomas-mangin added a comment to T2499: expose the configuration loading function.

https://github.com/vyos/vyos-1x/pull/422/files

Sat, May 23, 5:48 AM · VyOS 1.3 Equuleus
thomas-mangin claimed T2499: expose the configuration loading function.
Sat, May 23, 5:24 AM · VyOS 1.3 Equuleus
thomas-mangin created T2499: expose the configuration loading function.
Sat, May 23, 5:24 AM · VyOS 1.3 Equuleus

Fri, May 22

thomas-mangin added a comment to T2494: systemd dependencies issues.

It causes this:

9140 ?        Ss     0:00 /bin/bash /usr/libexec/vyos/init/vyos-router start
 9427 ?        S      0:00  \_ /bin/bash /usr/libexec/vyos/init/vyos-router start
 9428 ?        S      0:00      \_ python3 /usr/libexec/vyos/vyos-boot-config-loader.py /opt/vyatta/etc/config/config.boot
 9451 ?        S      0:00          \_ /opt/vyatta/sbin/my_commit
 9522 ?        S      0:00              \_ sudo sh -c VYOS_TAGNODE_VALUE='eth0' /usr/libexec/vyos/conf_mode/interfaces-ethernet.py
 9523 ?        Sl     0:00                  \_ python3 /usr/libexec/vyos/conf_mode/interfaces-ethernet.py
 9531 ?        R      0:00                      \_ /bin/cli-shell-api --show-active-only --show-show-defaults --show-ignore-edit showConfig
Fri, May 22, 3:12 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2494: systemd dependencies issues.
[Unit]
Description=VyOS HTTP API service
Fri, May 22, 2:29 PM · VyOS 1.3 Equuleus
thomas-mangin claimed T2494: systemd dependencies issues.
Fri, May 22, 2:22 PM · VyOS 1.3 Equuleus
thomas-mangin created T2494: systemd dependencies issues.
Fri, May 22, 2:10 PM · VyOS 1.3 Equuleus

Thu, May 21

thomas-mangin closed T2475: linting as Resolved.
Thu, May 21, 9:13 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2486: DNS records set via 'system static-host-mapping' return NXDOMAIN from 'service dns forwarding' after a request to a forwarded zone.
vyos@vyos:~$ dpkg -l | grep pdns
ii  pdns-recursor                    4.2.1-1pdns.buster                  amd64        PowerDNS Recursor
Thu, May 21, 12:00 PM · VyOS 1.3 Equuleus

Wed, May 20

thomas-mangin claimed T2431: Python validators are slow.
Wed, May 20, 7:53 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2431: Python validators are slow.

related to T2088 where performance is also being discussed.

Wed, May 20, 7:52 PM · VyOS 1.3 Equuleus
thomas-mangin claimed T2407: alternate installation for the vyos-1x python code.
Wed, May 20, 7:51 PM · VyOS 1.1.x
thomas-mangin added a comment to T2484: Migrate ConfigurationState out of interface-tunnel.

waiting for a decision on T2485 before doing this work

Wed, May 20, 7:44 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2485: move all the configuration code in a configuration folder.

https://github.com/vyos/vyos-1x/pull/418

Wed, May 20, 7:38 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2479: split the util file.

I have worked and provided a patch for T2485 .. It may be the right place to move it in.

Wed, May 20, 7:37 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2088: Increased boot time from 1.2.4 -> 1.3 rolling by 100%.

https://docs.google.com/document/d/1pKkxwq5eBm9eSTmyrSluDU1cx8NYqQRkQNdTB1tCSdk/edit?usp=sharing

Wed, May 20, 7:29 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2088: Increased boot time from 1.2.4 -> 1.3 rolling by 100%.

Every call to /bin/cli-shell-api --show-working-only --show-show-defaults --show-ignore-edit showConfig takes multiples seconds (6?)
/usr/libexec/vyos/conf_mode/system-timezone.py call it twice.
/usr/libexec/vyos/conf_mode/nat.py call it twice
/usr/libexec/vyos/conf_mode/interfaces-loopback.py call it twice ... etc.

Wed, May 20, 4:59 PM · VyOS 1.3 Equuleus
thomas-mangin claimed T2485: move all the configuration code in a configuration folder.
Wed, May 20, 11:22 AM · VyOS 1.3 Equuleus
thomas-mangin created T2485: move all the configuration code in a configuration folder.
Wed, May 20, 11:22 AM · VyOS 1.3 Equuleus
thomas-mangin claimed T2484: Migrate ConfigurationState out of interface-tunnel.
Wed, May 20, 11:20 AM · VyOS 1.3 Equuleus
thomas-mangin created T2484: Migrate ConfigurationState out of interface-tunnel.
Wed, May 20, 11:18 AM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2088: Increased boot time from 1.2.4 -> 1.3 rolling by 100%.

0-18 kernel boot
18-41 system starting inc FRR
70-120 the python most of the time is spend/wasted in cli-shell-api - so I would think reading the configuration file. If we can optimise / reduce this number of calls it would be very good.
140-220 is more or less firewall setup with vyatta-firewall / vyatta-upset.pl / ip6tables

Wed, May 20, 7:19 AM · VyOS 1.3 Equuleus

Tue, May 19

thomas-mangin added a comment to T2474: Building instructions with Docker need a little more detail.

I need to double-check (and may not get to it) but if you use a vyos-build to build current and then try to build crux, make iso is not happy. I am now building crux using the command in my post above, the only difference: clean vyos-build install before the git checkout crux.

Tue, May 19, 10:35 PM
thomas-mangin created T2479: split the util file.
Tue, May 19, 4:18 PM · VyOS 1.3 Equuleus

Mon, May 18

thomas-mangin added a comment to T2474: Building instructions with Docker need a little more detail.

ediing vyos make iso -d
https://github.com/thomas-mangin/vyos-hacker-toolkit

Mon, May 18, 9:30 PM
thomas-mangin added a comment to T2474: Building instructions with Docker need a little more detail.

Last time I generate crux I used the docker current to do it ...

Mon, May 18, 8:30 PM
thomas-mangin added a comment to T2475: linting.

https://github.com/vyos/vyos-1x/pull/412

Mon, May 18, 4:42 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2475: linting.

@runar just created this as I can not create a dev env without a phabricator entry. answer in 20 minutes :-)

Mon, May 18, 4:33 PM · VyOS 1.3 Equuleus
thomas-mangin claimed T2475: linting.
Mon, May 18, 4:33 PM · VyOS 1.3 Equuleus
thomas-mangin created T2475: linting.
Mon, May 18, 4:28 PM · VyOS 1.3 Equuleus

Sun, May 17

thomas-mangin added a comment to T2467: Restarting Flow Accounting Fails.

The run code could check the command name against a list of known "need sudo" commands and prepend it automagically so the command looks like normal but is auto-sudo'ed

Sun, May 17, 6:59 PM · VyOS 1.3 Equuleus

Wed, May 13

thomas-mangin added a comment to T2453: Improve serial console (add options to auto-detect or hard-set terminal size).

https://github.com/joejulian/xterm/blob/master/resize.c Not complicated to port in the vyos library, replacing the current code and therefore only run when required

Wed, May 13, 8:49 AM · VyOS 1.3 Equuleus

Tue, May 12

thomas-mangin added a comment to T2453: Improve serial console (add options to auto-detect or hard-set terminal size).

Should we trap the signal in vash, set an env value and use it with vyos?

Tue, May 12, 9:23 PM · VyOS 1.3 Equuleus

Sun, May 10

thomas-mangin added a comment to T2442: Move application of STP settings for bridge members from interfaces-bridge.py to Interface.add_to_bridge().

If enable is not clear as a name to say that it adds the feature to the class, it is a class decorator, then please suggest a better name.

Sun, May 10, 9:30 AM · VyOS 1.3 Equuleus
thomas-mangin closed T2372: VLAN: error on commit if main interface is disabled as Resolved.
Sun, May 10, 9:27 AM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2366: change the default for Interface creation to False.

I will look into the use case and see if I can think of something.

Sun, May 10, 9:23 AM

Sat, May 9

thomas-mangin added a comment to T2433: Increase performance using unix socket.

I have implemented a "validator program" which is an entry point which will locate a named python program and run it. It uses the import mechanism of python at startup so the setup time is very high.

Sat, May 9, 5:02 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2404: change mtu .

I raised this with the team and the idea of auto-detection does not get much support, which is fine, I just wanted to make sure I was doing the right thing. So I will finish this patch which will prevent some failure case and try to make the error message friendlier. Also, can look at where in the chain of change the MTU is performed to see if it can be rolled back.

Sat, May 9, 12:42 PM · VyOS 1.3 Equuleus

Fri, May 8

thomas-mangin added a comment to T2417: Python validator cleanup.

https://github.com/vyos/vyos-1x/pull/395

Fri, May 8, 11:51 AM · VyOS 1.3 Equuleus
thomas-mangin reopened T2417: Python validator cleanup as "In progress".
Fri, May 8, 11:50 AM · VyOS 1.3 Equuleus
thomas-mangin created T2437: New Config Code in the library.
Fri, May 8, 10:53 AM
thomas-mangin added a comment to T2409: At boot, effective config should not be equal to current config.

@jjakob it does nothing about the boot case but it would be much easier to add it to that code than what we do ATM.

Fri, May 8, 10:51 AM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2436: equuleus: Testing: vyos-1x: syntax checking python scripts in PR.

It seems that github has special rules for the .github file and that no PR can be done for it:
https://github.com/thomas-mangin/vyos-1x/blob/T2436/.github/workflows/pythonapp.yml

Fri, May 8, 10:22 AM
thomas-mangin added a comment to T2436: equuleus: Testing: vyos-1x: syntax checking python scripts in PR.

I would also suggest doing the same using github actions so that on push to your local repository to get a warning from github.

Fri, May 8, 9:54 AM
thomas-mangin added a comment to T2372: VLAN: error on commit if main interface is disabled.

Why do we need to remove all addresses from the interface when it is disabled?

Fri, May 8, 9:43 AM · VyOS 1.3 Equuleus
thomas-mangin closed T2417: Python validator cleanup as Resolved.
Fri, May 8, 9:42 AM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2409: At boot, effective config should not be equal to current config.

Can I throw https://github.com/vyos/vyos-1x/blob/current/src/conf_mode/interfaces-tunnel.py#L32 into the mix?

Fri, May 8, 9:26 AM · VyOS 1.3 Equuleus

Thu, May 7

thomas-mangin updated the task description for T2407: alternate installation for the vyos-1x python code.
Thu, May 7, 9:14 PM · VyOS 1.1.x
thomas-mangin added a comment to T2407: alternate installation for the vyos-1x python code.

How this can be implemented in practice was tested with https://github.com/thomas-mangin/vyos-extra

  • the program can be installed using pip/setuptools and the "vyosextra.main:main" entry point, generating a "vyos" program.
  • the "release" program in the root folder generates a self-contained executable (using the builtin python3 zipapp library) which can be place before in the path, taking precedence over the installed version.
  • each feature "vyos ssh", "vyos update" is a single program and could be installed independently using other entry points
  • dropping a program in the folder automatically registers it to the main "vyos" program, each program has a "def main()" with a docstring used for the "-h"
  • the assets in the data folder are converted into python dict and used when the program is a zipapp.
Thu, May 7, 9:13 PM · VyOS 1.1.x
thomas-mangin created T2433: Increase performance using unix socket.
Thu, May 7, 8:41 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2425: Rewrite policy prefix-list to XML/Python style.

@jjakob I was going to offer to do so this week if people agreed to give me a chance to show good it could be.

Thu, May 7, 1:20 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2425: Rewrite policy prefix-list to XML/Python style.

Using shell scripts would be a step back. The biggest part of the python script is the parsing of the vyos code. That's why I am suggesting that vyos command should be sent to a python daemon.
We can connect to it using IPC, and this can be done via a small C wrapper (or even directly in the caller's code to not even fork).

vyos@vyos# time bash -c ""
Thu, May 7, 1:16 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2404: change mtu .

I was also wondering if we should attempt an auto-detection of MTU on boot and save the result? This is why I was asking if this was the right approach.

Thu, May 7, 11:41 AM · VyOS 1.3 Equuleus

Wed, May 6

thomas-mangin added a comment to T2404: change mtu .

Not sure if this is the right approach or not. Feedback welcomed.

Wed, May 6, 11:44 PM · VyOS 1.3 Equuleus
thomas-mangin claimed T2426: vymgmt unparsable output.
Wed, May 6, 3:27 PM · Python Management Library
thomas-mangin added a comment to T2426: vymgmt unparsable output.

https://github.com/vyos/vyos-1x/pull/394

Wed, May 6, 3:27 PM · Python Management Library
thomas-mangin added a comment to T2407: alternate installation for the vyos-1x python code.
Wed, May 6, 8:06 AM · VyOS 1.1.x
thomas-mangin edited projects for T2407: alternate installation for the vyos-1x python code, added: VyOS 1.1.x; removed VyOS 2.0.x.
Wed, May 6, 8:05 AM · VyOS 1.1.x

Tue, May 5

thomas-mangin added a comment to T2426: vymgmt unparsable output.

ack - I will change this to make sure it is safe !

Tue, May 5, 6:35 PM · Python Management Library

May 3 2020

thomas-mangin added a comment to T2404: change mtu .

Some code should also be added to detect the parent MTU size and make sure a clan MTU is smaller than the parent

May 3 2020, 8:15 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2404: change mtu .

The mtu provided are reasonable and should not fail IMHO. I need to understand why Linux does not want to honour it.. hw limitation or other. If it is a limitation then we should detect it and report it to the user

May 3 2020, 8:05 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2404: change mtu .

That would only hide the problem. The MTU bug would still be here.

May 3 2020, 8:03 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2404: change mtu .

An issue to change the MTU should not fail the whole interface change but just this one but the code does not not allow this easily. I will try to work on this.

May 3 2020, 7:24 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2404: change mtu .

The reason seems to be that when the kernel can not change the MTU when writing to the sysfs, it will raise a OSError with the reason why.

May 3 2020, 4:59 PM · VyOS 1.3 Equuleus

May 2 2020

thomas-mangin created T2417: Python validator cleanup.
May 2 2020, 2:37 PM · VyOS 1.3 Equuleus

Apr 30 2020

thomas-mangin updated the task description for T2407: alternate installation for the vyos-1x python code.
Apr 30 2020, 7:08 PM · VyOS 1.1.x
thomas-mangin created T2407: alternate installation for the vyos-1x python code.
Apr 30 2020, 6:35 PM · VyOS 1.1.x

Apr 28 2020

thomas-mangin added a comment to T2394: dhcpv6 client does not start.

I had already reported before my refactor of the code that DHCPv6 does not work.
https://phabricator.vyos.net/T2268

Apr 28 2020, 6:53 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2394: dhcpv6 client does not start.

http://man7.org/linux/man-pages/man8/start-stop-daemon.8.html

EXIT STATUS
Apr 28 2020, 6:47 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2214: BGP peers dropping randomly.

https://vincent.bernat.ch/en/blog/2017-ipv6-route-lookup-linux

Apr 28 2020, 6:41 PM · VyOS 1.2 Crux
thomas-mangin added a comment to T2214: BGP peers dropping randomly.

Marek Isalski Today at 6:31 PM

Apr 28 2020, 6:38 PM · VyOS 1.2 Crux
thomas-mangin added a comment to T2184: OpenVPN op_mode tools broken.
vyos@vyos:~$ show interfaces openvpn vtun1
vtun1: <POINTOPOINT,MULTICAST,NOARP,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UNKNOWN group default qlen 100
    link/none
    inet 127.0.0.1 peer 10.255.1.2/32 scope host vtun1
       valid_lft forever preferred_lft forever
    inet6 fe80::a6ba:dc03:94c5:6b42/64 scope link stable-privacy
       valid_lft forever preferred_lft forever
Apr 28 2020, 10:58 AM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2184: OpenVPN op_mode tools broken.

@jjakob sorry for wasting your time here :-( I will try to replicate.

Apr 28 2020, 8:57 AM · VyOS 1.3 Equuleus

Apr 27 2020

thomas-mangin added a comment to T2214: BGP peers dropping randomly.

@Merjin is trying this:

sudo sysctl -w net.ipv6.route.max_size=131072

https://serverfault.com/questions/902161/linux-host-randomly-stops-answering-ipv6-neighbor-solicitation-requests
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=861115

Apr 27 2020, 3:29 PM · VyOS 1.2 Crux
thomas-mangin added a comment to T2390: unify the chmod_ function of VyOS.

To explain the permission for the user/group/world are expressed in octal (3 bits) so 755 is binary for 111 101 101

Apr 27 2020, 2:47 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2184: OpenVPN op_mode tools broken.

@jjakob can we close this task ?

Apr 27 2020, 2:03 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2388: template rendering should create folder and set permission.

https://github.com/vyos/vyos-1x/pull/381

Apr 27 2020, 11:18 AM · VyOS 1.3 Equuleus