Page MenuHomeVyOS Platform
Feed Advanced Search

Tue, Jun 30

thomas-mangin added a comment to T2665: vyos.xml.defaults for tag nodes.

Re-reading the entry, I am now unsure what you believe should be different.

Tue, Jun 30, 9:25 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2665: vyos.xml.defaults for tag nodes.

Yes, I should parse the tagNode and insert them into the default data.

Tue, Jun 30, 5:03 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2662: get_config_dict includes node name as key only for tag and leaf nodes.

Thank you for this explaining what is happening. I would indeed rather tag were used as keys.https://github.com/vyos/vyos-1x/pull/484/files#diff-58fc6df0879046cf057488b9a641ca6eR261

Tue, Jun 30, 7:57 AM · VyOS 1.3 Equuleus

Mon, Jun 29

thomas-mangin added a comment to T2636: get_config_dict() shall always return a list on <multi/> nodes.

Yes, so there is no way to know at parsing time (unless you have two elements) that this is a multi-element. Something "computer-friendly" would generate:

test {
    something [one two]
}

which I am sure we all agree is not as good as what we have now.

Mon, Jun 29, 1:24 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2636: get_config_dict() shall always return a list on <multi/> nodes.

The data returned by get_config_dict should always have the same format to prevent any function using it to have to check if one element is a list or a string.

Mon, Jun 29, 9:41 AM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2653: "set interfaces" Python handler code improvements - next iteration.

Agreeing and defining the name of the keys to be used in the dict passed to verify/generate/apply, would be very beneficial for the project.
The current code does this by calling a number of helper function (so that all interface have the same keys) but this is not defined or/and enforced.

Mon, Jun 29, 9:31 AM · VyOS 1.3 Equuleus

Sun, Jun 28

thomas-mangin added a comment to T2659: Add fastnetmon (DDoS detection) support.

Should we provide the script which perform the change and define what action can be performed in the xml?

Sun, Jun 28, 9:22 AM · VyOS 1.3 Equuleus

Sat, Jun 27

thomas-mangin added a comment to T2582: Script daemon to offload processing during commit.

The work to perform the get_config/verify/generate/apply in python is already available in this tree:
https://github.com/thomas-mangin/vyos-1x/tree/T2522

Sat, Jun 27, 12:53 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2656: XML: Python default dictionary returns wrong dictionary level(s).

@cpo, you can change the defaults from True to False in the patch if this is what you want to do.

Sat, Jun 27, 12:50 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2656: XML: Python default dictionary returns wrong dictionary level(s).

https://github.com/vyos/vyos-1x/pull/479

Sat, Jun 27, 12:49 PM · VyOS 1.3 Equuleus

Fri, Jun 26

thomas-mangin closed T2057: Generalised Interface configuration as Resolved.
Fri, Jun 26, 1:32 PM · VyOS 1.3 Equuleus

Thu, Jun 25

thomas-mangin added a comment to T2582: Script daemon to offload processing during commit.

I propose to provide alternatives is_ function using the new XML code. I will provide a patch for review.

Thu, Jun 25, 2:51 PM · VyOS 1.3 Equuleus
thomas-mangin claimed T2643: Show Interface Command Issues.
Thu, Jun 25, 1:55 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2038: repository organisation change.

I agree that this kind of changes are better done at the start of a development cycle.

Thu, Jun 25, 1:53 PM · Restricted Project
thomas-mangin added a comment to T2649: Ensure configration mode scripts conform to coding guidelines.

There is really no difference between calling Config() and using it functions in the code - as is done by every module - vs having the class inherit from it as I do not use any private ( _ prefixed ) functions. I can modify the code to have self.config as an object of the class instead but IMO this is cosmetic and does not change anything with the API and coding guideline.

Thu, Jun 25, 1:48 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2640: Running VyOS inside Docker containers.

not willing to take the lead on this task but happy to help.

Thu, Jun 25, 1:29 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2649: Ensure configration mode scripts conform to coding guidelines.

@jestabro could you please clarify how interfaces-tunnel.py is not following the guideline. The class it uses to generate the dict is internal to the get_config() function and the dict API is respected.

Thu, Jun 25, 1:28 PM · VyOS 1.3 Equuleus

Wed, Jun 24

thomas-mangin added a comment to T2637: Vlan is not removed from the system.

The problem also probably exists with vif_s .. it needs to be investigated.

Wed, Jun 24, 10:28 AM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2637: Vlan is not removed from the system.

https://github.com/vyos/vyos-1x/pull/474/files

Wed, Jun 24, 10:27 AM · VyOS 1.3 Equuleus
thomas-mangin claimed T2637: Vlan is not removed from the system.
Wed, Jun 24, 10:05 AM · VyOS 1.3 Equuleus
thomas-mangin closed T2634: remove autogeneration of interface "ip section" from vyatta-cfg-system as Resolved.
Wed, Jun 24, 8:24 AM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2634: remove autogeneration of interface "ip section" from vyatta-cfg-system.

was done part of T2633

Wed, Jun 24, 8:23 AM · VyOS 1.3 Equuleus

Tue, Jun 23

thomas-mangin added a comment to T2630: Allow Interface MTU over 9000.

could have the range 68-65536 but it may be a bit on the extreme side.

Tue, Jun 23, 7:28 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2630: Allow Interface MTU over 9000.

https://github.com/vyos/vyos-1x/pull/473 was merged so now need to agree same limits for the XML.

Tue, Jun 23, 7:27 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2630: Allow Interface MTU over 9000.

I have a PR for this (not changing the XML limiting range) for review ATM.

Tue, Jun 23, 7:25 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2587: Cannot enable the interface when the MTU is set to less than 1280.

related to T2630

Tue, Jun 23, 1:22 PM · VyOS 1.3 Equuleus
thomas-mangin created T2634: remove autogeneration of interface "ip section" from vyatta-cfg-system.
Tue, Jun 23, 1:20 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2633: Error with arp_accept on tun interface.
vyos@vyos# set interfaces tunnel tun0 description '*** SITE1 ***'
[edit]
vyos@vyos# set interfaces tunnel tun0 encapsulation 'gre-bridge'
[edit]
vyos@vyos# set interfaces tunnel tun0 local-ip '10.0.3.239'
[edit]
vyos@vyos# set interfaces tunnel tun0 remote-ip '10.0.32.240'
[edit]
vyos@vyos# set interfaces tunnel tun0 ip enable-arp-accept
[edit]
vyos@vyos# set interfaces tunnel tun0 ip enable-arp-announce
[edit]
Tue, Jun 23, 1:14 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2633: Error with arp_accept on tun interface.

https://github.com/vyos/vyos-1x/pull/472

Tue, Jun 23, 1:07 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2629: VXLAN interfaces don't actually allow you to configure most settings.

Breaking user existing configs should be a no-no. If the options can be used that way under Linux, then we should not restrict it if it is not invalid. If we intend to prevent it then we would need a way to warn users clearly and we have no framework for this ATM.

Tue, Jun 23, 7:20 AM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2630: Allow Interface MTU over 9000.

Need to add max MTU to operational mode and create a new validator using it and applying it to the xml. The only question being if the information is always available.

Tue, Jun 23, 7:12 AM · VyOS 1.3 Equuleus
thomas-mangin claimed T2630: Allow Interface MTU over 9000.
Tue, Jun 23, 7:09 AM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2630: Allow Interface MTU over 9000.

I see no issue with the proposed solution.

Tue, Jun 23, 7:09 AM · VyOS 1.3 Equuleus

Sat, Jun 20

thomas-mangin added a comment to T2621: show interfaces repeats interface description if it is longer then an arbitrary number of characters.

LOL - I could have commited :-) Thanks !

Sat, Jun 20, 8:34 PM · VyOS 1.3 Equuleus

Mon, Jun 15

thomas-mangin closed T2591: show command has wrong interfaces ordering as Resolved.
Mon, Jun 15, 3:40 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2591: show command has wrong interfaces ordering.

@Dmitry correct same bug - thank you. resolved.

Mon, Jun 15, 3:40 PM · VyOS 1.3 Equuleus
thomas-mangin closed T2576: "show interfaces" does not return VTI as Resolved.
Mon, Jun 15, 3:39 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2599: "show interfaces" does not list VIF interfaces in ascending order.

https://github.com/vyos/vyos-1x/pull/457

Mon, Jun 15, 3:23 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2576: "show interfaces" does not return VTI.

The patch was merged and the issue should be resolved with the next ISO.

Mon, Jun 15, 2:10 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2576: "show interfaces" does not return VTI.

https://github.com/vyos/vyos-1x/pull/456

Mon, Jun 15, 11:53 AM · VyOS 1.3 Equuleus

Thu, Jun 11

thomas-mangin added a comment to T2582: Script daemon to offload processing during commit.

Thank you very much for the POC. Very useful to understand the proposed design.

Thu, Jun 11, 12:45 PM · VyOS 1.3 Equuleus

Wed, Jun 10

thomas-mangin added a comment to T2576: "show interfaces" does not return VTI.

hello Fabio, could you please show me how the vti interfaces are presented under Linux so I can fix the code. I thought I had properly ported the code from Perl to Python must I must have misunderstood something.

Wed, Jun 10, 12:50 PM · VyOS 1.3 Equuleus

Fri, Jun 5

thomas-mangin added a comment to T2549: repository restructuration suggestions.

Yes, we need to try/except the apply section (the other should never fail but we could still catch errors to not leave the system in an unknown state) but when applying the reverse configuration (ie: invert effective and new and re-apply) one must then be careful if that fails too (we do not want a forever loop :p). The code already runs all the get_dict and all the verify first, so we will only apply if all is ok, but still issues could occur.

Fri, Jun 5, 4:32 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2522: Python CLI.

@jjakob control-R should be implemented. It is a feature I use too and expect it - just did not think it was worth a demo 0.0 release - there is plenty to improve with the code in the branch - it surely has bugs -as I said POC :-)

Fri, Jun 5, 3:37 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2549: repository restructuration suggestions.

generate should make a backup of the previous file before generating the new one. It will then make it possible to create the rollback as a file move and service reload.

Fri, Jun 5, 2:39 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2522: Python CLI.

@jjakob the code can be installed on a router (using my vyos update tool - after running vyos setup router )

Fri, Jun 5, 2:33 PM · VyOS 1.3 Equuleus

Thu, Jun 4

thomas-mangin created T2549: repository restructuration suggestions.
Thu, Jun 4, 8:37 PM · VyOS 1.3 Equuleus

Jun 2 2020

thomas-mangin added a comment to T2522: Python CLI.

It should not be too hard to convert the current parser to read.
https://gist.github.com/thomas-mangin/17a450a3e26a4cc41902475c0a1dfe5f

Jun 2 2020, 11:32 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2522: Python CLI.

@jjakob you are right, there is no shell integration and this is using the python promt-toolkit library to handle input/output.

Jun 2 2020, 8:10 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2539: Issues with parsing ip range for source nat translation address.

Thank you for reporting this issue, it looks like that parser allows ranges of IP address (IP hyphen IP) but the parser does not. You could get around using CIDR notation but this indeed need looking into.

Jun 2 2020, 7:44 PM · VyConf
thomas-mangin added a comment to T2542: OpenVPN client tap interfaces not coming up.

should help to go further in the testing, but it is still failing on set_state but I do not know why it should be done if the interface is managed by openvpn. The relevant code is:

Jun 2 2020, 7:22 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2522: Python CLI.

As a side note, if there is a need to migrate between backends, it would be possible to change the code to have an option to indicate which storage should be used and allow loading from one, saving to another as long as the XML schema is the same.

Jun 2 2020, 3:15 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2522: Python CLI.

I see the POC as complete and conclusive, it would only make sense to spend more time on things once this is done (or to add support for control via HTTP/API).

Jun 2 2020, 3:12 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2522: Python CLI.

Configuring 100 dummy interfaces (no thread) on a local VirtualBox, all tests done from boot

Jun 2 2020, 2:10 PM · VyOS 1.3 Equuleus

Jun 1 2020

thomas-mangin added a comment to T2418: Interfaces completion (list_interfaces.py) is slow.

Thank you for this long answer @jjakob. I want to demonstrate that a full python solution can provide the performance we need. I appreciate that changing the Vyatta code need to be done carefully with many consideration about backward compatibility. What I am doing is surely 1.4 material. However I do not believe this is as hard to achieve as everyone may think, and as working code is the best way to discuss code design, that is what I am doing.

Jun 1 2020, 12:34 AM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2522: Python CLI.

The cli is mostly functional. I am able to validate the data as it is typed in conf mode (the CLI has both completion and validation working), as soon as delete and show (the current show is "show configuration commands") are implemented, it will be mostly usable. The code can already load a configuration from file, allow some "set" edit and then allow the use of save (the config format is a number of "set" commands, one per line), respect the initialisation order of the XML.

Jun 1 2020, 12:29 AM · VyOS 1.3 Equuleus

May 31 2020

thomas-mangin added a comment to T2088: Increased boot time from 1.2.4 -> 1.3 rolling by 100%.

I used @runar code on my branch working on T2522 .. Configuring 100 dummy interface went from 42 to 8 seconds.

May 31 2020, 11:56 PM · VyOS 1.3 Equuleus

May 30 2020

thomas-mangin added a comment to T2418: Interfaces completion (list_interfaces.py) is slow.
vyos@vyos# diff -u /usr/libexec/vyos/completion/list_interfaces.py list_interfaces.py
--- /usr/libexec/vyos/completion/list_interfaces.py	2020-03-21 19:47:22.000000000 +0000
+++ list_interfaces.py	2020-05-30 18:45:30.564000000 +0000
@@ -39,4 +39,7 @@
     print(" ".join([intf for intf in matching("bondable") if '.' not in intf]))
May 30 2020, 6:08 PM · VyOS 1.3 Equuleus
thomas-mangin updated subscribers of T2522: Python CLI.

I just had a look at VyConf and it is excellent, I fear that no one but @dmbaturin can maintain participate to it.
Also, VyConf will still need to fork all the python code and unless we have a resolution to T2088 - I am not sure what the best path forward will be

May 30 2020, 5:38 PM · VyOS 1.3 Equuleus
thomas-mangin updated subscribers of T2418: Interfaces completion (list_interfaces.py) is slow.

I tried to get a flamegraph showing what I was wanting to say but .. do not look very clear :-(

May 30 2020, 3:45 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2418: Interfaces completion (list_interfaces.py) is slow.

May 30 2020, 3:30 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2500: vyos-build scripts/build-packages builds vyos-1x with version 0.0-no.git.tag.

I believe it was git pull —tags which fixed it for me ..

May 30 2020, 1:53 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2436: equuleus: Testing: vyos-1x: syntax checking python scripts in PR.

Many scripts also so do implement if name == “main

May 30 2020, 1:49 PM

May 26 2020

thomas-mangin added a comment to T2425: Rewrite policy prefix-list to XML/Python style.

Also related to T2088

May 26 2020, 2:42 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2494: systemd dependencies issues.

https://github.com/vyos/vyos-1x/pull/423

May 26 2020, 2:24 PM · VyOS 1.3 Equuleus
thomas-mangin updated the task description for T2522: Python CLI.
May 26 2020, 2:03 PM · VyOS 1.3 Equuleus
thomas-mangin claimed T2522: Python CLI.
May 26 2020, 1:55 PM · VyOS 1.3 Equuleus
thomas-mangin created T2522: Python CLI.
May 26 2020, 1:54 PM · VyOS 1.3 Equuleus

May 24 2020

thomas-mangin added a comment to T2501: Cannot recover from failed boot config load.

The called code can return 3 - in that case in that case _run should return an empty string

May 24 2020, 9:51 AM · VyOS 1.3 Equuleus

May 23 2020

thomas-mangin added a comment to T2457: IPv6 ping by address not working.
diff --git a/src/op_mode/ping.py b/src/op_mode/ping.py
index 45b06aa9..f723933b 100644
--- a/src/op_mode/ping.py
+++ b/src/op_mode/ping.py
@@ -210,7 +210,7 @@ if __name__ == '__main__':
     try:
         ip = socket.gethostbyname(host)
     except socket.gaierror:
-        sys.exit(f'ping: Unknown host: {host}')
+        ip = host
May 23 2020, 5:34 PM
thomas-mangin added a comment to T2499: expose the configuration loading function.

https://github.com/vyos/vyos-1x/pull/422/files

May 23 2020, 5:48 AM · VyOS 1.3 Equuleus
thomas-mangin claimed T2499: expose the configuration loading function.
May 23 2020, 5:24 AM · VyOS 1.3 Equuleus
thomas-mangin created T2499: expose the configuration loading function.
May 23 2020, 5:24 AM · VyOS 1.3 Equuleus

May 22 2020

thomas-mangin added a comment to T2494: systemd dependencies issues.

It causes this:

9140 ?        Ss     0:00 /bin/bash /usr/libexec/vyos/init/vyos-router start
 9427 ?        S      0:00  \_ /bin/bash /usr/libexec/vyos/init/vyos-router start
 9428 ?        S      0:00      \_ python3 /usr/libexec/vyos/vyos-boot-config-loader.py /opt/vyatta/etc/config/config.boot
 9451 ?        S      0:00          \_ /opt/vyatta/sbin/my_commit
 9522 ?        S      0:00              \_ sudo sh -c VYOS_TAGNODE_VALUE='eth0' /usr/libexec/vyos/conf_mode/interfaces-ethernet.py
 9523 ?        Sl     0:00                  \_ python3 /usr/libexec/vyos/conf_mode/interfaces-ethernet.py
 9531 ?        R      0:00                      \_ /bin/cli-shell-api --show-active-only --show-show-defaults --show-ignore-edit showConfig
May 22 2020, 3:12 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2494: systemd dependencies issues.
[Unit]
Description=VyOS HTTP API service
May 22 2020, 2:29 PM · VyOS 1.3 Equuleus
thomas-mangin claimed T2494: systemd dependencies issues.
May 22 2020, 2:22 PM · VyOS 1.3 Equuleus
thomas-mangin created T2494: systemd dependencies issues.
May 22 2020, 2:10 PM · VyOS 1.3 Equuleus

May 21 2020

thomas-mangin closed T2475: linting as Resolved.
May 21 2020, 9:13 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2486: DNS records set via 'system static-host-mapping' return NXDOMAIN from 'service dns forwarding' after a request to a forwarded zone.
vyos@vyos:~$ dpkg -l | grep pdns
ii  pdns-recursor                    4.2.1-1pdns.buster                  amd64        PowerDNS Recursor
May 21 2020, 12:00 PM · VyOS 1.3 Equuleus

May 20 2020

thomas-mangin claimed T2431: Python validators are slow.
May 20 2020, 7:53 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2431: Python validators are slow.

related to T2088 where performance is also being discussed.

May 20 2020, 7:52 PM · VyOS 1.3 Equuleus
thomas-mangin claimed T2407: alternate installation for the vyos-1x python code.
May 20 2020, 7:51 PM · VyOS 1.1.x
thomas-mangin added a comment to T2484: Migrate ConfigurationState out of interface-tunnel.

waiting for a decision on T2485 before doing this work

May 20 2020, 7:44 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2485: move all the configuration code in a configuration folder.

https://github.com/vyos/vyos-1x/pull/418

May 20 2020, 7:38 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2479: split the util file.

I have worked and provided a patch for T2485 .. It may be the right place to move it in.

May 20 2020, 7:37 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2088: Increased boot time from 1.2.4 -> 1.3 rolling by 100%.

https://docs.google.com/document/d/1pKkxwq5eBm9eSTmyrSluDU1cx8NYqQRkQNdTB1tCSdk/edit?usp=sharing

May 20 2020, 7:29 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2088: Increased boot time from 1.2.4 -> 1.3 rolling by 100%.

Every call to /bin/cli-shell-api --show-working-only --show-show-defaults --show-ignore-edit showConfig takes multiples seconds (6?)
/usr/libexec/vyos/conf_mode/system-timezone.py call it twice.
/usr/libexec/vyos/conf_mode/nat.py call it twice
/usr/libexec/vyos/conf_mode/interfaces-loopback.py call it twice ... etc.

May 20 2020, 4:59 PM · VyOS 1.3 Equuleus
thomas-mangin claimed T2485: move all the configuration code in a configuration folder.
May 20 2020, 11:22 AM · VyOS 1.3 Equuleus
thomas-mangin created T2485: move all the configuration code in a configuration folder.
May 20 2020, 11:22 AM · VyOS 1.3 Equuleus
thomas-mangin claimed T2484: Migrate ConfigurationState out of interface-tunnel.
May 20 2020, 11:20 AM · VyOS 1.3 Equuleus
thomas-mangin created T2484: Migrate ConfigurationState out of interface-tunnel.
May 20 2020, 11:18 AM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2088: Increased boot time from 1.2.4 -> 1.3 rolling by 100%.

0-18 kernel boot
18-41 system starting inc FRR
70-120 the python most of the time is spend/wasted in cli-shell-api - so I would think reading the configuration file. If we can optimise / reduce this number of calls it would be very good.
140-220 is more or less firewall setup with vyatta-firewall / vyatta-upset.pl / ip6tables

May 20 2020, 7:19 AM · VyOS 1.3 Equuleus

May 19 2020

thomas-mangin added a comment to T2474: Building instructions with Docker need a little more detail.

I need to double-check (and may not get to it) but if you use a vyos-build to build current and then try to build crux, make iso is not happy. I am now building crux using the command in my post above, the only difference: clean vyos-build install before the git checkout crux.

May 19 2020, 10:35 PM
thomas-mangin created T2479: split the util file.
May 19 2020, 4:18 PM · VyOS 1.3 Equuleus

May 18 2020

thomas-mangin added a comment to T2474: Building instructions with Docker need a little more detail.

ediing vyos make iso -r crux -d
https://github.com/thomas-mangin/vyos-hacker-toolkit

May 18 2020, 9:30 PM
thomas-mangin added a comment to T2474: Building instructions with Docker need a little more detail.

Last time I generate crux I used the docker current to do it ...
(but I could not this time...)

May 18 2020, 8:30 PM
thomas-mangin added a comment to T2475: linting.

https://github.com/vyos/vyos-1x/pull/412

May 18 2020, 4:42 PM · VyOS 1.3 Equuleus
thomas-mangin added a comment to T2475: linting.

@runar just created this as I can not create a dev env without a phabricator entry. answer in 20 minutes :-)

May 18 2020, 4:33 PM · VyOS 1.3 Equuleus
thomas-mangin claimed T2475: linting.
May 18 2020, 4:33 PM · VyOS 1.3 Equuleus
thomas-mangin created T2475: linting.
May 18 2020, 4:28 PM · VyOS 1.3 Equuleus