This is dependent on T2029, PR 224, and should only be merged after that PR.

This is dependent on T2029, PR 224, and should only be merged after that PR.

This PR changes the syntax of the trailing version string of the config file (cf. above), as represented during config migration, and the parsing by which configtree splits the config file into the config section proper and the version string.

Binary package in debian unstable; 20191221

This is now in upstream live-build: commit b6ad08c2709fbdab0b96852d9bfeb52d753b89bc

Final test before merging:
https://github.com/vyos/vyos-1x/compare/current...jestabro:T1585?expand=1

Merged.

This is not a backport candidate until 'T834: accel-ppp: l2tp implementation' has been backported.

This is not a backport candidate until the 'T989: accel-ppp: IPoE implementation' has been backported.

This is not a backport candidate until the full OpenVPN rewrite is backported.

Parent task not yet listed for backport; discussed with @zsdc for possible inclusion in future.

Actually, upon reflection, the parser error is just too many terms on the line, hitting HandlingError; the rare exception exists, but is misleading, so 'use cases and/or implementation' ...

As expected,
(1) This is a parser error
(2) It is independent of any specific configuration script; it can be reproduced by calling conf.get_config_dict() with uncommitted changes, from any conf_mode script.

Yes, thanks, c-po; the revised settings (above) are consistent with defaults and behaviour for both crux and equuleus.

I will backport this, unless objections ...

For consistency with the relative sizes set by CLI in the conf_mode script (system-ip.py), the default params should be:

The size of an ARP cache entry is 384 bytes (x86-64), so the change will add ~720k -- ~3 MiB, which seems reasonable. I will add the suggested settings to sysctl defaults.

https://github.com/vyos/vyos-1x/compare/current...jestabro:syntax-version?expand=1

Revising this design, following discussion with dmbaturin; implementation in T1962.

Move to 'Needs testing'; repo linked below. Add example of third-party package, and test, before PR.

This appears to be a moving target in at least one sense:
The package lists I now see differ from what is listed in the files above; one notable difference is a missing 'systemd-sysv':

My guess would be missing live-tools in the recommends=false case; live-tools replaces update-initramfs with its version. I'm building to check ...

To avoid confusion, this will only be in the equuleus branch:
https://github.com/vyos/vyos-1x/compare/equuleus...jestabro:T1585?expand=1

Initial version for equuleus here:
https://github.com/jestabro/vyos-1x/tree/T1585

This requirement needs to be applied to 'running_config' as well, in case of (1) editing at the level of an unset node (parse error); (2) reading effective_value(s) in configuration mode (lacking full paths).

Thanks; this is necessary when (1) editing at the level of an unset node; (2) reading effective_value(s) in configuration mode. I will extend the original fix.

@Merijn if you are still willing to test, I can provide build instructions, if you need. I noticed that you had been working with @hagbard recently on your build environment; if you are willing to use docker, I can give you step-by-step instructions to build with these patches.