PR259 fixes this

Another bug:

Same issue for me (1.3-rolling-202003221506). I needed to add this to the script "/usr/lib/python3/dist-packages/vyos/ifconfig/wireguard.py":

@wornet-mwo in 1.2.5 and rolling

Can confirm that this can be closed now.

@dmbaturin can you look 2 PR for implement option with ignore old transaction-script states?
https://github.com/vyos/vyos-1x/pull/255
https://github.com/vyos/vyos-replace/pull/7
Can we add this in 1.2.6?

Thanks for testing @jjakob

Couldn't reproduce in 1.3-rolling-20200319

Is there any way I can help test this? I was trying to setup the same, but lack of link-local support prevents me from adding a v6 BGP peer without allocating IP addresses to the link.

Sorry, the task name was wrong, "save" resets it, "commit" doesn't. Personally I prefer if it'd stay the same, but I don't care if it resets it either.

Personally this is behavior I agree with.

Tested successfully in Crux.

@alien Can you please share your config, I can't reproduce it. The op function will be moved into the the ops script out of the ifconfig class, which caused the issue due to restructuring out internal class architecture.

Following script more appreciated

/run/atop/atop.acct {
	rotate 0
	nomissingok
	size 100M
	postrotate
		PIDFILE=/run/atop.pid
		if [ -e $PIDFILE ] && \
			ps -p `cat $PIDFILE` | grep 'atop$' > /dev/null
		then
			kill -15 `cat $PIDFILE`
			rm $PIDFILE
		fi
		sleep 1
		/etc/init.d/atop restart
	endscript
}

Sometimes we use this for detecting memleak and some clients issues with high CPU load. When we get users /var/log/atop* then we can reproduce locally and find wrong process, memleaking etc.

Nice. What is atop actually used for?

Thanks @syncer and @c-po . As I understand logrotate run once per day. I hope this will be enough

vyos@vyos:~# ls /etc/cron.daily/ | grep logro
logrotate
vyos@vyos:~# cat /etc/crontab | grep daily
25 6	* * *	root	test -x /usr/sbin/anacron || ( cd / && run-parts --report /etc/cron.daily )

So, now I have logrotate script for atop on my test router

cat /etc/logrotate.d/atop 
/run/atop/atop.acct {
	rotate 0
	nomissingok
	size 50M
	postrotate
		/etc/init.d/atop restart
	endscript
}

With manually run, seems all works

logrotate /etc/logrotate.d/atop --verbose
reading config file /etc/logrotate.d/atop

As the mtu on an ip network could exceed 1500b it is not so strange to allow larger than 1500b frames on the tunnel. But this could be adjusted to follow the max mtu values on ethernet interfaces. As taken from my head max mtu on ethernet is about 9000b

https://github.com/vyos/vyos-build/pull/95